Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1969063002: copy TypeName.type when we clone the AST (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M lib/src/compiler/code_generator.dart View 2 chunks +6 lines, -4 lines 2 comments Download
M lib/src/compiler/reify_coercions.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
4 years, 7 months ago (2016-05-11 17:21:32 UTC) #2
vsm
lgtm https://codereview.chromium.org/1969063002/diff/1/lib/src/compiler/code_generator.dart File lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/1969063002/diff/1/lib/src/compiler/code_generator.dart#newcode526 lib/src/compiler/code_generator.dart:526: return js.call('dart.dynamic'); Throw sounds better to me. Do ...
4 years, 7 months ago (2016-05-11 17:26:07 UTC) #3
Jennifer Messerly
thanks! https://codereview.chromium.org/1969063002/diff/1/lib/src/compiler/code_generator.dart File lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/1969063002/diff/1/lib/src/compiler/code_generator.dart#newcode526 lib/src/compiler/code_generator.dart:526: return js.call('dart.dynamic'); On 2016/05/11 17:26:07, vsm wrote: > ...
4 years, 7 months ago (2016-05-11 17:52:32 UTC) #4
Jennifer Messerly
4 years, 7 months ago (2016-05-11 17:53:01 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
841d2c645fb589542f20aea6b06bf2aa3fd1ce4d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698