chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc - Issue 19690003: Extension activity log database refactoring (step 3)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

Issue 19690003: Extension activity log database refactoring (step 3) (Closed) Base URL: http://git.chromium.org/chromium/src.git@refactor2

Patch Set: Do not set bad BlockedChromeActivityDetail::Reason values Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/stream_noargs_ui_policy_unittest.cc ('k') | chrome/browser/extensions/extension_function_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

diff --git a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

index 841f09d6c5629421a2584ad9482bc9b6fcebc193..14312592f42d4111c77a275becc3b9ce71f0aa0d 100644

--- a/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

+++ b/chrome/browser/extensions/api/activity_log_private/activity_log_private_api_unittest.cc

@@ -28,6 +28,10 @@ using api::activity_log_private::ExtensionActivity;

class ActivityLogApiUnitTest : public testing::Test {

};

+// TODO(felt): These are the old unit tests from before the activity log Action

+// class and database refactoring. These need to be updated, but since the

+// private API will be reworked anyway these are just disabled for now.

+#if 0

TEST_F(ActivityLogApiUnitTest, ConvertBlockedAction) {

scoped_refptr<Action> action(

new BlockedAction(kExtensionId,

@@ -101,6 +105,6 @@ TEST_F(ActivityLogApiUnitTest, ConvertDomAction) {

ASSERT_EQ(kExtra,

*(result->dom_activity_detail->extra.get()));

}

+#endif

-} // extensions

+} // namespace extensions