Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc

Issue 19690003: Extension activity log database refactoring (step 3) (Closed) Base URL: http://git.chromium.org/chromium/src.git@refactor2
Patch Set: Do not set bad BlockedChromeActivityDetail::Reason values Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc
diff --git a/chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc b/chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc
index 180b8023d599070a4af63961efd457c458e0137b..f977cc62270644bf3c773906eaeab7a733a428f9 100644
--- a/chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc
+++ b/chrome/browser/extensions/activity_log/stream_noargs_ui_policy.cc
@@ -16,15 +16,16 @@ StreamWithoutArgsUIPolicy::StreamWithoutArgsUIPolicy(Profile* profile)
StreamWithoutArgsUIPolicy::~StreamWithoutArgsUIPolicy() {}
-scoped_ptr<base::ListValue> StreamWithoutArgsUIPolicy::ProcessArguments(
- ActionType action_type,
- const std::string& name,
- const base::ListValue* args) const {
- if (action_type == ACTION_DOM ||
- arg_whitelist_api_.find(name) != arg_whitelist_api_.end()) {
- return FullStreamUIPolicy::ProcessArguments(action_type, name, args).Pass();
+void StreamWithoutArgsUIPolicy::ProcessArguments(
+ scoped_refptr<Action> action) const {
+ if (action->action_type() == Action::ACTION_DOM_ACCESS ||
+ action->action_type() == Action::ACTION_DOM_EVENT ||
+ action->action_type() == Action::ACTION_DOM_XHR ||
+ action->action_type() == Action::ACTION_WEB_REQUEST ||
+ arg_whitelist_api_.find(action->api_name()) != arg_whitelist_api_.end()) {
+ // No stripping of arguments
} else {
- return make_scoped_ptr(new ListValue());
+ action->set_args(scoped_ptr<ListValue>());
}
}

Powered by Google App Engine
This is Rietveld 408576698