Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: chrome/browser/extensions/activity_log/blocked_actions.h

Issue 19690003: Extension activity log database refactoring (step 3) (Closed) Base URL: http://git.chromium.org/chromium/src.git@refactor2
Patch Set: Do not set bad BlockedChromeActivityDetail::Reason values Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/blocked_actions.h
diff --git a/chrome/browser/extensions/activity_log/blocked_actions.h b/chrome/browser/extensions/activity_log/blocked_actions.h
deleted file mode 100644
index e6f4beb0a9add0bdd6f58258f9addcd7b6556a5e..0000000000000000000000000000000000000000
--- a/chrome/browser/extensions/activity_log/blocked_actions.h
+++ /dev/null
@@ -1,64 +0,0 @@
-// Copyright (c) 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_BLOCKED_ACTIONS_H_
-#define CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_BLOCKED_ACTIONS_H_
-
-#include "chrome/browser/extensions/activity_log/activity_actions.h"
-
-namespace extensions {
-
-// This class describes API calls that ran into permissions or quota problems.
-// See APIActions for API calls that succeeded.
-class BlockedAction : public Action {
- public:
- // These values should not be changed. Append any additional values to the
- // end with sequential numbers.
- enum Reason {
- UNKNOWN = 0,
- ACCESS_DENIED = 1,
- QUOTA_EXCEEDED = 2,
- };
-
- // You must supply the id, time, api_call, and reason.
- BlockedAction(const std::string& extension_id,
- const base::Time& time,
- const std::string& api_call, // the blocked API call
- const std::string& args, // the arguments
- const Reason reason, // the reason it's blocked
- const std::string& extra); // any extra logging info
-
- // Record the action in the database.
- virtual bool Record(sql::Connection* db) OVERRIDE;
-
- virtual scoped_ptr<api::activity_log_private::ExtensionActivity>
- ConvertToExtensionActivity() OVERRIDE;
-
- // Print a BlockedAction as a string for debugging purposes.
- virtual std::string PrintForDebug() OVERRIDE;
-
- // Helper methods for recording the values into the db.
- const std::string& api_call() const { return api_call_; }
- const std::string& args() const { return args_; }
- const std::string& extra() const { return extra_; }
-
- // Helper method for debugging.
- std::string ReasonAsString() const;
-
- protected:
- virtual ~BlockedAction();
-
- private:
- std::string api_call_;
- std::string args_;
- Reason reason_;
- std::string extra_;
-
- DISALLOW_COPY_AND_ASSIGN(BlockedAction);
-};
-
-} // namespace extensions
-
-#endif // CHROME_BROWSER_EXTENSIONS_ACTIVITY_LOG_BLOCKED_ACTIONS_H_
-
« no previous file with comments | « chrome/browser/extensions/activity_log/api_actions.cc ('k') | chrome/browser/extensions/activity_log/blocked_actions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698