src/objects-inl.h - Issue 1968953002: [runtime] Implement encodeURI as single runtime function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1968953002: [runtime] Implement encodeURI as single runtime function. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix isalnum() bug Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index dd2d2df384bd4c64ab41759832154472cf59f8ff..13cedfc491811d6f7aa1a154d769e51502766179 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -3651,7 +3651,8 @@ uint16_t SeqOneByteString::SeqOneByteStringGet(int index) {

void SeqOneByteString::SeqOneByteStringSet(int index, uint16_t value) {

- DCHECK(index >= 0 && index < length() && value <= kMaxOneByteCharCode);

+ DCHECK(index >= 0 && index < length());

+ DCHECK(value <= kMaxOneByteCharCode);

WRITE_BYTE_FIELD(this, kHeaderSize + index * kCharSize,

static_cast<byte>(value));

}