Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: src/factory.h

Issue 1968953002: [runtime] Implement encodeURI as single runtime function. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Fix isalnum() bug Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/factory.cc » ('j') | src/js/uri.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.h
diff --git a/src/factory.h b/src/factory.h
index 81252ebe13abcc9f44f78198417b994dd07a822f..1854773d4bd9503ee8299c552dbbc6b329081778 100644
--- a/src/factory.h
+++ b/src/factory.h
@@ -560,6 +560,10 @@ class Factory final {
return NewRangeError(MessageTemplate::kInvalidStringLength);
}
+ Handle<Object> NewMakeURIError() {
Yang 2016/05/12 07:39:20 Can we call this NewURIError and have it call into
Franzi 2016/05/13 09:42:02 Done.
+ return NewURIError(MessageTemplate::kURIMalformed);
+ }
+
Handle<Object> NewError(Handle<JSFunction> constructor,
MessageTemplate::Template template_index,
Handle<Object> arg0 = Handle<Object>(),
@@ -577,6 +581,8 @@ class Factory final {
DECLARE_ERROR(ReferenceError)
DECLARE_ERROR(SyntaxError)
DECLARE_ERROR(TypeError)
+ DECLARE_ERROR(URIError)
Yang 2016/05/12 07:39:20 Let's not declare this helper.
Franzi 2016/05/13 09:42:02 Done.
+
#undef DEFINE_ERROR
Handle<String> NumberToString(Handle<Object> number,
« no previous file with comments | « no previous file | src/factory.cc » ('j') | src/js/uri.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698