[runtime] Implement encodeURI as single runtime function.

test/mjsunit/uri.js

 // Copyright 2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 35 matching lines @@
 var s7 = String.fromCharCode(cc7);
 var cc8_1 = 0xD800;
 var cc8_2 = 0xDC00;
 var s8 = String.fromCharCode(cc8_1)+String.fromCharCode(cc8_2);
 var cc9_1 = 0xDBFF;
 var cc9_2 = 0xDFFF;
 var s9 = String.fromCharCode(cc9_1)+String.fromCharCode(cc9_2);
 var cc10 = 0xE000;
 var s10 = String.fromCharCode(cc10);
 
-assertEquals('%7D', encodeURI(s1));
-assertEquals('%00', encodeURI(s2));
-assertEquals('%C2%80', encodeURI(s3));
+assertEquals('%7D', encodeURI(s1)); // }

[Yang, 2016/05/12 07:39:21]

We usually use two whitespaces before a comment.

[Franzi, 2016/05/13 09:42:03]

Done.

+assertEquals('%00', encodeURI(s2)); // 0
+assertEquals('%C2%80', encodeURI(s3)); // Padding character
 assertEquals('%D5%95', encodeURI(s4));
 assertEquals('%DF%BF', encodeURI(s5));
 assertEquals('%E0%A0%80', encodeURI(s6));
 assertEquals('%EA%BB%AE', encodeURI(s7));
 assertEquals('%F0%90%80%80', encodeURI(s8));
 assertEquals('%F4%8F%BF%BF', encodeURI(s9));
 assertEquals('%EE%80%80', encodeURI(s10));
 
+assertEquals('Hello%20World!', encodeURI("Hello World!"));
+
+
 assertEquals(cc1, decodeURI(encodeURI(s1)).charCodeAt(0));
 assertEquals(cc2, decodeURI(encodeURI(s2)).charCodeAt(0));
 assertEquals(cc3, decodeURI(encodeURI(s3)).charCodeAt(0));
 assertEquals(cc4, decodeURI(encodeURI(s4)).charCodeAt(0));
 assertEquals(cc5, decodeURI(encodeURI(s5)).charCodeAt(0));
 assertEquals(cc6, decodeURI(encodeURI(s6)).charCodeAt(0));
 assertEquals(cc7, decodeURI(encodeURI(s7)).charCodeAt(0));
 assertEquals(cc8_1, decodeURI(encodeURI(s8)).charCodeAt(0));
 assertEquals(cc8_2, decodeURI(encodeURI(s8)).charCodeAt(1));
 assertEquals(cc9_1, decodeURI(encodeURI(s9)).charCodeAt(0));
 assertEquals(cc9_2, decodeURI(encodeURI(s9)).charCodeAt(1));
 assertEquals(cc10, decodeURI(encodeURI(s10)).charCodeAt(0));
 
 assertEquals("", decodeURI(""));
 assertEquals("", encodeURI(""));
 
-function test(string) {
+function testIdempotent(string) {
   assertEquals(string, decodeURI(encodeURI(string)));
 }
 
-test("\u1234\u0123\uabcd");
-test("abcd");
-test("ab<\u1234\u0123");
-test("ab\u1234<\u0123");
+testIdempotent("\u1234\u0123\uabcd");
+testIdempotent("abcd");
+testIdempotent("ab<\u1234\u0123");
+testIdempotent("ab\u1234<\u0123");
 
 
 (function TestDeleteCharCodeAt() {
   assertEquals('abc', encodeURI('abc'));
   assertEquals('abc', decodeURI('abc'));
   assertTrue(delete String.prototype.charCodeAt);
   assertTrue(delete String.prototype.charAt);
   assertEquals('abc', encodeURI('abc'));
   assertEquals('abc', decodeURI('abc'));
 })();