Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1512)

Unified Diff: src/wasm/wasm-opcodes.h

Issue 1968943002: [wasm] Introduce custom asm.js bytecodes for loads and stores. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@wasm_asmjs_convert
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/wasm/wasm-opcodes.h
diff --git a/src/wasm/wasm-opcodes.h b/src/wasm/wasm-opcodes.h
index c6457503e67100c6ab0444c51c1819d281f8f254..764c5030f5f735554273c8f52780c6dfb805990a 100644
--- a/src/wasm/wasm-opcodes.h
+++ b/src/wasm/wasm-opcodes.h
@@ -261,26 +261,23 @@ const WasmCodePosition kNoCodePosition = -1;
V(I32AsmjsDivU, 0xd1, i_ii) \
V(I32AsmjsRemS, 0xd2, i_ii) \
V(I32AsmjsRemU, 0xd3, i_ii) \
+ V(I32AsmjsLoadMem8S, 0xd4, i_i) \
+ V(I32AsmjsLoadMem8U, 0xd5, i_i) \
+ V(I32AsmjsLoadMem16S, 0xd6, i_i) \
+ V(I32AsmjsLoadMem16U, 0xd7, i_i) \
+ V(I32AsmjsLoadMem, 0xd8, i_i) \
+ V(F32AsmjsLoadMem, 0xd9, f_i) \
+ V(F64AsmjsLoadMem, 0xda, d_i) \
+ V(I32AsmjsStoreMem8, 0xdb, i_ii) \
+ V(I32AsmjsStoreMem16, 0xdc, i_ii) \
+ V(I32AsmjsStoreMem, 0xdd, i_ii) \
+ V(F32AsmjsStoreMem, 0xde, f_if) \
+ V(F64AsmjsStoreMem, 0xdf, d_id) \
V(I32AsmjsSConvertF32, 0xe0, i_f) \
V(I32AsmjsUConvertF32, 0xe1, i_f) \
V(I32AsmjsSConvertF64, 0xe2, i_d) \
V(I32AsmjsUConvertF64, 0xe3, i_d)
-/* TODO(titzer): introduce compatibility opcodes for these asm.js ops \
-V(I32AsmjsLoad8S, 0xd4, i_i) \ \
-V(I32AsmjsLoad8U, 0xd5, i_i) \ \
-V(I32AsmjsLoad16S, 0xd6, i_i) \ \
-V(I32AsmjsLoad16U, 0xd7, i_i) \ \
-V(I32AsmjsLoad, 0xd8, i_i) \ \
-V(F32AsmjsLoad, 0xd9, f_i) \ \
-V(F64AsmjsLoad, 0xda, d_i) \ \
-V(I32AsmjsStore8, 0xdb, i_i) \ \
-V(I32AsmjsStore16, 0xdc, i_i) \ \
-V(I32AsmjsStore, 0xdd, i_ii) \ \
-V(F32AsmjsStore, 0xde, i_if) \ \
-V(F64AsmjsStore, 0xdf, i_id) \ \
-*/
-
// All opcodes.
#define FOREACH_OPCODE(V) \
FOREACH_CONTROL_OPCODE(V) \

Powered by Google App Engine
This is Rietveld 408576698