chrome/test/data/beforeunload_slow.html - Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/beforeunload_slow.html

Issue 1968933002: Fix: tabs slow to response to beforeunload are closed prematurely. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Correct order of checks Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <title>Loading...</title>

	4 <script>

	5 window.onbeforeunload = function(e) {

	6 // Delay must be slightly bigger than

	7 // RenderViewHostImpl::kUnloadTimeoutMS to trigger

	8 // "renderer unresponsive".

	9 var delay = 1500;

	10 var finishTime = new Date().getTime() + delay;

	11 while (new Date() < finishTime) {}

	12 return null;

	13 };

	14 </script>

	15 </head>

	16 <body>

	17 <p>Navigate to another page to trigger beforeunload handler.</p>

	18 </body>

	19 </html>

OLD	NEW