Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1968903002: Revert of Remove Oilpan-only StyleSheet/ test failures from TestExpectations (Closed)

Created:
4 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 7 months ago
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove Oilpan-only StyleSheet/ test failures from TestExpectations (patchset #6 id:100001 of https://codereview.chromium.org/1904423002/ ) Reason for revert: speculative revert to see whether this caused crbug.com/610340 BUG=610340 Original issue's description: > Remove Oilpan-only StyleSheet/ test failures from TestExpectations > > BUG=585328 > > Committed: https://crrev.com/23d02793c61cf69b1818cd007cc39db1d2238b09 > Cr-Commit-Position: refs/heads/master@{#390285} TBR=haraken@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com,yukishiino@chromium.org,keishi@chromium.org # CQ was green on first patchset, manual rebase of TestExpectations NOTRY=true BUG=585328 Committed: https://crrev.com/24abea527df01d35b7afd8656009f09944019d8b Cr-Commit-Position: refs/heads/master@{#392907}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -77 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/StyleSheet/detached-parent-rule-without-wrapper.html View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/StyleSheet/detached-parent-rule-without-wrapper-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/StyleSheet/detached-stylesheet-without-wrapper.html View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/StyleSheet/detached-stylesheet-without-wrapper-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-declaration-parent-rule-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-parent-rule-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/StyleSheet/gc-parent-stylesheet-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/platform/oilpan/fast/dom/StyleSheet/detached-parent-rule-without-wrapper-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/platform/oilpan/fast/dom/StyleSheet/gc-parent-rule-expected.txt View 1 1 chunk +2 lines, -3 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleRuleCustom.cpp View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/custom.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleDeclaration.idl View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSStyleRule.idl View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 23 (12 generated)
jochen (gone - plz use gerrit)
Created Revert of Remove Oilpan-only StyleSheet/ test failures from TestExpectations
4 years, 7 months ago (2016-05-11 08:43:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968903002/1
4 years, 7 months ago (2016-05-11 08:44:09 UTC) #2
haraken
LGTM
4 years, 7 months ago (2016-05-11 08:48:23 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/219647)
4 years, 7 months ago (2016-05-11 11:12:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968903002/1
4 years, 7 months ago (2016-05-11 11:14:56 UTC) #7
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/LayoutTests/TestExpectations: While running git apply --index -3 -p1; error: patch ...
4 years, 7 months ago (2016-05-11 12:47:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968903002/1
4 years, 7 months ago (2016-05-11 12:54:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968903002/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968903002/250001
4 years, 7 months ago (2016-05-11 13:00:48 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968903002/250001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968903002/250001
4 years, 7 months ago (2016-05-11 13:04:23 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:250001)
4 years, 7 months ago (2016-05-11 13:08:24 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-11 13:09:49 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24abea527df01d35b7afd8656009f09944019d8b
Cr-Commit-Position: refs/heads/master@{#392907}

Powered by Google App Engine
This is Rietveld 408576698