Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(688)

Issue 1968893002: Remove certain non-standard properties from Intl (Closed)

Created:
4 years, 7 months ago by Dan Ehrenberg
Modified:
4 years, 7 months ago
CC:
Michael Hablich, Michael Achenbach, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove certain non-standard properties from Intl This patch removes the following properties, as their use count is very low, they are V8-only, and not on a standards track. - v8Parse - resolved - pattern v8BreakIterator is left in as it has significantly more usage. BUG=v8:3785 R=adamk,jshin@chromium.org Committed: https://crrev.com/0bd50885e8c7021900541520662a6232b3deb30c Cr-Commit-Position: refs/heads/master@{#36190}

Patch Set 1 #

Patch Set 2 : Add missing file #

Total comments: 2

Patch Set 3 : Fix nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -12 lines) Patch
M BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 6 chunks +6 lines, -0 lines 0 comments Download
M src/flag-definitions.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/js/i18n.js View 1 2 12 chunks +27 lines, -11 lines 0 comments Download
A src/js/intl-extra.js View 1 1 chunk +20 lines, -0 lines 0 comments Download
M src/js/prologue.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/intl/date-format/parse-MMMdy.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/intl/date-format/parse-invalid-input.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/intl/date-format/parse-mdy.js View 1 chunk +2 lines, -0 lines 0 comments Download
A test/intl/extra-flag.js View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
A test/intl/no-extra-flag.js View 1 chunk +23 lines, -0 lines 0 comments Download
M test/intl/number-format/format-is-bound.js View 2 chunks +3 lines, -1 line 0 comments Download
M test/intl/number-format/parse-currency.js View 1 chunk +2 lines, -0 lines 0 comments Download
M test/intl/number-format/parse-invalid-input.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 27 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968893002/1
4 years, 7 months ago (2016-05-11 06:49:50 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/17457) v8_linux64_avx2_rel_ng on ...
4 years, 7 months ago (2016-05-11 06:51:21 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968893002/1
4 years, 7 months ago (2016-05-11 06:54:20 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968893002/1
4 years, 7 months ago (2016-05-11 06:58:40 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/17458) v8_linux64_asan_rel_ng on ...
4 years, 7 months ago (2016-05-11 07:00:01 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968893002/20001
4 years, 7 months ago (2016-05-11 07:13:40 UTC) #14
Dan Ehrenberg
4 years, 7 months ago (2016-05-11 07:19:37 UTC) #15
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 07:45:55 UTC) #17
adamk
lgtm % comment https://codereview.chromium.org/1968893002/diff/20001/test/intl/extra-flag.js File test/intl/extra-flag.js (right): https://codereview.chromium.org/1968893002/diff/20001/test/intl/extra-flag.js#newcode7 test/intl/extra-flag.js:7: // Turning on the creates removes ...
4 years, 7 months ago (2016-05-11 23:03:02 UTC) #18
Dan Ehrenberg
https://codereview.chromium.org/1968893002/diff/20001/test/intl/extra-flag.js File test/intl/extra-flag.js (right): https://codereview.chromium.org/1968893002/diff/20001/test/intl/extra-flag.js#newcode7 test/intl/extra-flag.js:7: // Turning on the creates removes the non-standard properties ...
4 years, 7 months ago (2016-05-11 23:57:35 UTC) #20
Dan Ehrenberg
4 years, 7 months ago (2016-05-11 23:57:37 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968893002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968893002/40001
4 years, 7 months ago (2016-05-11 23:57:43 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-12 00:32:54 UTC) #25
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 00:35:01 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0bd50885e8c7021900541520662a6232b3deb30c
Cr-Commit-Position: refs/heads/master@{#36190}

Powered by Google App Engine
This is Rietveld 408576698