DevTools: update default focus element in security panel

DevTools: update default focus element in security panel

BUG=610680
Committed: https://crrev.com/6fca666c1c3da8fc9b67b58c18c94d06c66c5efc
Cr-Commit-Position: refs/heads/master@{#393559}

[luoe, 2016-05-11 00:54:36]

luoe@chromium.org changed reviewers:
+ lushnikov@chromium.org

[luoe, 2016-05-11 00:54:36]

This CL updates the SecurityPanel's defaultFocusedElement.

The focusable elements on the left of the panel are in a TreeOutlineInShadow
instance.  A TreeOutlineInShadow has both an innerElement and a regular element
(inherited from TreeOutline).  When a user switches to the 'Security' tab, there
are 2 calls to focus()

1) SecurityPanel.wasShown, which calls innerElement.focus()
2) SecurityPanel.focus, which calls element.focus(), by default

The panel should really have just one default focused element, and innerElement
is the one that makes the 'Overview' section blue.

[luoe, 2016-05-11 00:56:55]

^ My bad, the words above should say:

"A TreeOutlineInShadow has both an innerElement (inherited from TreeOutline) and
a regular element"

[luoe, 2016-05-11 01:12:10]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 01:12:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968843002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968843002/1

[commit-bot: I haz the power, 2016-05-11 02:15:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 02:15:07]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-05-12 19:15:44]

lgtm

https://codereview.chromium.org/1968843002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/1968843002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:320:
this.innerElement = this.element;
let's call this contentElement to be consistent with WI.Widget

[luoe, 2016-05-12 21:28:28]

https://codereview.chromium.org/1968843002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/1968843002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:320:
this.innerElement = this.element;
On 2016/05/12 19:15:44, lushnikov wrote:
> let's call this contentElement to be consistent with WI.Widget

Turns out there was already a "_contentElement", which was identical to
"innerElement".  Switched instances to plain, public "contentElement".

[luoe, 2016-05-12 21:31:59]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-12 21:32:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968843002/20001

[commit-bot: I haz the power, 2016-05-12 22:53:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-12 22:53:01]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-05-13 17:07:08]

The CQ bit was checked by luoe@chromium.org

[luoe, 2016-05-13 17:07:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
lushnikov@chromium.org
Link to the patchset: https://codereview.chromium.org/1968843002/#ps20001
(title: "Address patch 1 comments")

[commit-bot: I haz the power, 2016-05-13 17:07:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968843002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968843002/20001

[commit-bot: I haz the power, 2016-05-13 17:14:55]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-13 17:16:59]

Description was changed from

==========
DevTools: update default focus element in security panel

BUG=610680
==========

to

==========
DevTools: update default focus element in security panel

BUG=610680

Committed: https://crrev.com/6fca666c1c3da8fc9b67b58c18c94d06c66c5efc
Cr-Commit-Position: refs/heads/master@{#393559}
==========

[commit-bot: I haz the power, 2016-05-13 17:17:00]

Patchset 2 (id:??) landed as
https://crrev.com/6fca666c1c3da8fc9b67b58c18c94d06c66c5efc
Cr-Commit-Position: refs/heads/master@{#393559}