Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1968843002: DevTools: update default focus element in security panel (Closed)

Created:
4 years, 7 months ago by luoe
Modified:
4 years, 7 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: update default focus element in security panel BUG=610680 Committed: https://crrev.com/6fca666c1c3da8fc9b67b58c18c94d06c66c5efc Cr-Commit-Position: refs/heads/master@{#393559}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address patch 1 comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M third_party/WebKit/Source/devtools/front_end/security/SecurityPanel.js View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js View 1 5 chunks +10 lines, -11 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
luoe
This CL updates the SecurityPanel's defaultFocusedElement. The focusable elements on the left of the panel ...
4 years, 7 months ago (2016-05-11 00:54:36 UTC) #2
luoe
^ My bad, the words above should say: "A TreeOutlineInShadow has both an innerElement (inherited ...
4 years, 7 months ago (2016-05-11 00:56:55 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968843002/1
4 years, 7 months ago (2016-05-11 01:12:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-11 02:15:07 UTC) #7
lushnikov
lgtm https://codereview.chromium.org/1968843002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right): https://codereview.chromium.org/1968843002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js#newcode320 third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:320: this.innerElement = this.element; let's call this contentElement to ...
4 years, 7 months ago (2016-05-12 19:15:44 UTC) #8
luoe
https://codereview.chromium.org/1968843002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right): https://codereview.chromium.org/1968843002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js#newcode320 third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:320: this.innerElement = this.element; On 2016/05/12 19:15:44, lushnikov wrote: > ...
4 years, 7 months ago (2016-05-12 21:28:28 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968843002/20001
4 years, 7 months ago (2016-05-12 21:32:26 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-12 22:53:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968843002/20001
4 years, 7 months ago (2016-05-13 17:07:40 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-13 17:14:55 UTC) #17
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 17:17:00 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6fca666c1c3da8fc9b67b58c18c94d06c66c5efc
Cr-Commit-Position: refs/heads/master@{#393559}

Powered by Google App Engine
This is Rietveld 408576698