Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 1968773002: [Merge to 51] Make the Android test apks depend on their run_ scripts (Closed)

Created:
4 years, 7 months ago by mikecase (-- gone --)
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[Merge to 51] Make the Android test apks depend on their run_ scripts The dependency should actually be the other way around, but for compatibility with GYP, it has to go this way. Original CL: https://codereview.chromium.org/1893063002 BUG=610479 R=dpranke@chromium.org, jbudorick@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/8111f61175b968fc412fa5eaba3c2c1db4710ee9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -4 lines) Patch
M build/config/android/internal_rules.gni View 1 chunk +9 lines, -4 lines 0 comments Download
M testing/test.gni View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mikecase (-- gone --)
Tested locally. Build event_unittests_apk and the test runner script was built with no errors.
4 years, 7 months ago (2016-05-10 23:17:28 UTC) #2
jbudorick
lgtm
4 years, 7 months ago (2016-05-10 23:22:00 UTC) #3
mikecase (-- gone --)
+ OWNER for src/testing/
4 years, 7 months ago (2016-05-10 23:48:30 UTC) #5
mikecase (-- gone --)
4 years, 7 months ago (2016-05-11 21:41:17 UTC) #7
Dirk Pranke
lgtm.
4 years, 7 months ago (2016-05-11 22:33:31 UTC) #8
mikecase (-- gone --)
4 years, 7 months ago (2016-05-11 22:39:42 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8111f61175b968fc412fa5eaba3c2c1db4710ee9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698