MD User Manager: Creates new browser window for last active profile if one is not available

MD User Manager: Creates new browser window for last active profile if one is not available

It also fixes the following two edge cases:

-when there is no last used profile, and the default profile is not already loaded, it won't attempt to load it synchronously which results in thread restriction assertion error.

-When the last used profile is the guest profile, it uses incognito mode.

BUG=610447
Committed: https://crrev.com/a85d497c0177b8a02edfdee430aeeb41a5d098c1
Cr-Commit-Position: refs/heads/master@{#394119}

[Moe, 2016-05-10 21:36:43]

Patchset #1 (id:1) has been deleted

[Moe, 2016-05-10 21:37:47]

Description was changed from

==========
MD User Manager: Creates new browser window for last active profile if one is
not available

BUG=610447
==========

to

==========
MD User Manager: Creates new browser window for last active profile if one is
not available

It also fixes the edge case where the last used profile is deleted and guest
profile is used as the last used profile.

BUG=610447
==========

[Moe, 2016-05-10 21:37:47]

mahmadi@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[Moe, 2016-05-10 21:38:00]

Anthony, Please review this CL.

[Moe, 2016-05-11 13:56:25]

Patchset #1 (id:20001) has been deleted

[Moe, 2016-05-11 14:00:59]

Description was changed from

==========
MD User Manager: Creates new browser window for last active profile if one is
not available

It also fixes the edge case where the last used profile is deleted and guest
profile is used as the last used profile.

BUG=610447
==========

to

==========
MD User Manager: Creates new browser window for last active profile if one is
not available

It also fixes the following two edge cases:

-when there is no last used profile, and the default profile is not already
loaded, it won't attempt to load it synchronously which results in thread
restriction assertion error.

-When the last used profile is the guest profile, it uses incognito mode.

BUG=610447
==========

[anthonyvd, 2016-05-11 18:04:04]

c/b/profiles/profile_manager.* lgtm

https://codereview.chromium.org/1968703002/diff/40001/chrome/browser/profiles...
File chrome/browser/profiles/profile_manager.h (right):

https://codereview.chromium.org/1968703002/diff/40001/chrome/browser/profiles...
chrome/browser/profiles/profile_manager.h:62: // Returns true if incognito mode
is forced.
nit: expand a bit on what this implies.

[Moe, 2016-05-13 17:18:11]

mahmadi@chromium.org changed reviewers:
+ rogerta@chromium.org

[Moe, 2016-05-13 17:18:12]

Thanks Anthony. Roger, Please review c/b/ui/webui/signin/

https://codereview.chromium.org/1968703002/diff/40001/chrome/browser/profiles...
File chrome/browser/profiles/profile_manager.h (right):

https://codereview.chromium.org/1968703002/diff/40001/chrome/browser/profiles...
chrome/browser/profiles/profile_manager.h:62: // Returns true if incognito mode
is forced.
On 2016/05/11 18:04:03, anthonyvd wrote:
> nit: expand a bit on what this implies.

Done.

[Roger Tawa OOO till Jul 10th, 2016-05-16 15:05:54]

lgtm

[Moe, 2016-05-17 13:54:32]

Thank you!

[Moe, 2016-05-17 13:54:37]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-05-17 13:54:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
anthonyvd@chromium.org
Link to the patchset: https://codereview.chromium.org/1968703002/#ps60001
(title: "Addressed comment")

[commit-bot: I haz the power, 2016-05-17 13:54:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968703002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968703002/60001

[commit-bot: I haz the power, 2016-05-17 14:21:05]

Description was changed from

==========
MD User Manager: Creates new browser window for last active profile if one is
not available

It also fixes the following two edge cases:

-when there is no last used profile, and the default profile is not already
loaded, it won't attempt to load it synchronously which results in thread
restriction assertion error.

-When the last used profile is the guest profile, it uses incognito mode.

BUG=610447
==========

to

==========
MD User Manager: Creates new browser window for last active profile if one is
not available

It also fixes the following two edge cases:

-when there is no last used profile, and the default profile is not already
loaded, it won't attempt to load it synchronously which results in thread
restriction assertion error.

-When the last used profile is the guest profile, it uses incognito mode.

BUG=610447
==========

[commit-bot: I haz the power, 2016-05-17 14:21:07]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-05-17 14:22:34]

Description was changed from

==========
MD User Manager: Creates new browser window for last active profile if one is
not available

It also fixes the following two edge cases:

-when there is no last used profile, and the default profile is not already
loaded, it won't attempt to load it synchronously which results in thread
restriction assertion error.

-When the last used profile is the guest profile, it uses incognito mode.

BUG=610447
==========

to

==========
MD User Manager: Creates new browser window for last active profile if one is
not available

It also fixes the following two edge cases:

-when there is no last used profile, and the default profile is not already
loaded, it won't attempt to load it synchronously which results in thread
restriction assertion error.

-When the last used profile is the guest profile, it uses incognito mode.

BUG=610447

Committed: https://crrev.com/a85d497c0177b8a02edfdee430aeeb41a5d098c1
Cr-Commit-Position: refs/heads/master@{#394119}
==========

[commit-bot: I haz the power, 2016-05-17 14:22:35]

Patchset 2 (id:??) landed as
https://crrev.com/a85d497c0177b8a02edfdee430aeeb41a5d098c1
Cr-Commit-Position: refs/heads/master@{#394119}