third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp - Issue 1968683003: Simplify SVGSMILElement::notifyDependentsIntervalChanged loop breaker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp

Issue 1968683003: Simplify SVGSMILElement::notifyDependentsIntervalChanged loop breaker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp

diff --git a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp

index 34ebfa02ff086decd5eb31f2e106473bd8d4c85d..ab184256008bd45070cf699147831ddd04cb550c 100644

--- a/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp

+++ b/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp

@@ -1222,8 +1222,7 @@ void SVGSMILElement::notifyDependentsIntervalChanged()

ASSERT(m_interval.begin.isFinite());

// |loopBreaker| is used to avoid infinite recursions which may be caused from:

// |notifyDependentsIntervalChanged| -> |createInstanceTimesFromSyncbase| -> |add{Begin,End}Time| -> |{begin,end}TimeChanged| -> |notifyDependentsIntervalChanged|

- // |loopBreaker| is defined as a Persistent<HeapHashSet<Member<SVGSMILElement>>>. This won't cause leaks because it is guaranteed to be empty after the root |notifyDependentsIntervalChanged| has exited.

- DEFINE_STATIC_LOCAL(HeapHashSet<Member<SVGSMILElement>>, loopBreaker, (new HeapHashSet<Member<SVGSMILElement>>));

+ DEFINE_STATIC_LOCAL(HashSet<UntracedMember<SVGSMILElement>>, loopBreaker, ());

haraken 2016/05/11 11:53:23 Maybe worth adding a comment why the untraced memb

sof 2016/05/11 12:11:20 yes, done.

if (!loopBreaker.add(this).isNewEntry)

return;

« no previous file with comments | « no previous file | no next file » | no next file with comments »