Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.h

Issue 1968653005: Set width=height=1 of mouse like pointer events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/PointerEventManager.h
diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.h b/third_party/WebKit/Source/core/input/PointerEventManager.h
index ce6dfa48e1027ffdbdbadafcbe4ed4d1ea609506..13e5588b9fde2c77f1727e4fa004f723e31ec940 100644
--- a/third_party/WebKit/Source/core/input/PointerEventManager.h
+++ b/third_party/WebKit/Source/core/input/PointerEventManager.h
@@ -36,7 +36,7 @@ public:
WebInputEventResult handleTouchEvents(
const PlatformTouchEvent&);
- // Sends node transition events mouseout/leave/over/enter to the
+ // Sends boundary events mouseout/leave/over/enter to the
// corresponding targets. This function sends pointerout/leave/over/enter
// only when isFrameBoundaryTransition is true which indicates the
// transition is over the document boundary and not only the elements border
@@ -44,10 +44,10 @@ public:
// then the event is a compatibility event like those created by touch
// and in that case the corresponding pointer events will be handled by
// sendTouchPointerEvent for example and there is no need to send pointer
- // transition events. Note that normal mouse events (e.g. mousemove/down/up)
- // and their corresponding transition events will be handled altogether by
+ // boundary events. Note that normal mouse events (e.g. mousemove/down/up)
+ // and their corresponding boundary events will be handled altogether by
// sendMousePointerEvent function.
- void sendMouseAndPossiblyPointerNodeTransitionEvents(
+ void sendMouseAndPossiblyPointerBoundaryEvents(
Node* exitedNode,
Node* enteredNode,
const PlatformMouseEvent&,
@@ -103,7 +103,7 @@ private:
// Returns whether the event is consumed or not.
WebInputEventResult sendTouchPointerEvent(EventTarget*, PointerEvent*);
- void sendNodeTransitionEvents(
+ void sendBoundaryEvents(
EventTarget* exitedTarget,
EventTarget* enteredTarget,
PointerEvent*,
@@ -112,9 +112,11 @@ private:
void setNodeUnderPointer(PointerEvent*,
EventTarget*, bool sendEvent = true);
- // Returns whether the pointer capture is changed. In this case this
- // function will take care of transition events and setNodeUnderPointer
- // should not send transition events.
+ // Processes the assignment of |m_pointerCaptureTarget| from |m_pendingPointerCaptureTarget|
+ // and sends the got/lostpointercapture events, as per the spec:
+ // https://w3c.github.io/pointerevents/#process-pending-pointer-capture
+ // Returns whether the pointer capture is changed. When pointer capture is changed,
+ // this function will take care of boundary events.
bool processPendingPointerCapture(
PointerEvent*,
EventTarget*,
@@ -122,8 +124,8 @@ private:
bool sendMouseEvent = false);
// Processes the capture state of a pointer, updates node under
- // pointer, and sends corresponding transition events for pointer if
- // setPointerPosition is true. It also sends corresponding transition events
+ // pointer, and sends corresponding boundary events for pointer if
+ // setPointerPosition is true. It also sends corresponding boundary events
// for mouse if sendMouseEvent is true.
void processCaptureAndPositionOfPointerEvent(
PointerEvent*,
« no previous file with comments | « third_party/WebKit/Source/core/input/EventHandler.cpp ('k') | third_party/WebKit/Source/core/input/PointerEventManager.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698