Set width=height=1 of mouse like pointer events

third_party/WebKit/Source/core/events/PointerEventFactory.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/events/PointerEventFactory.h"
 
 #include "core/frame/FrameView.h"
 #include "platform/geometry/FloatSize.h"
 
 namespace blink {
@@ skipping 74 matching lines @@
         && type != EventTypeNames::pointerleave);
     pointerEventInit.setCancelable(type != EventTypeNames::pointerenter
         && type != EventTypeNames::pointerleave && type != EventTypeNames::pointercancel);
 }
 
 PointerEvent* PointerEventFactory::create(
     const AtomicString& mouseEventName, const PlatformMouseEvent& mouseEvent,
     EventTarget* relatedTarget,
     LocalDOMWindow* view)
 {
+    DCHECK(mouseEventName == EventTypeNames::mousemove
+        || mouseEventName == EventTypeNames::mousedown
+        || mouseEventName == EventTypeNames::mouseup);
+
     AtomicString pointerEventName = pointerEventNameForMouseEventName(mouseEventName);
     unsigned buttons = MouseEvent::platformModifiersToButtons(mouseEvent.getModifiers());
     PointerEventInit pointerEventInit;
 
     setIdTypeButtons(pointerEventInit, mouseEvent.pointerProperties(), buttons);
     setBubblesAndCancelable(pointerEventInit, pointerEventName);
 
     pointerEventInit.setScreenX(mouseEvent.globalPosition().x());
     pointerEventInit.setScreenY(mouseEvent.globalPosition().y());
 
     IntPoint locationInFrameZoomed;
     if (view && view->frame() && view->frame()->view()) {
         LocalFrame* frame = view->frame();
         FrameView* frameView = frame->view();
         IntPoint locationInContents = frameView->rootFrameToContents(mouseEvent.position());
         locationInFrameZoomed = frameView->contentsToFrame(locationInContents);
         float scaleFactor = 1 / frame->pageZoomFactor();
         locationInFrameZoomed.scale(scaleFactor, scaleFactor);
     }
 
     // Set up initial values for coordinates.
     pointerEventInit.setClientX(locationInFrameZoomed.x());
     pointerEventInit.setClientY(locationInFrameZoomed.y());
 
     if (pointerEventName == EventTypeNames::pointerdown
         || pointerEventName == EventTypeNames::pointerup) {
         pointerEventInit.setButton(mouseEvent.button());
-    } else {
-        // TODO(crbug.com/587955): We are setting NoButton for transition
-        // pointerevents should be resolved as part of this bug
+    } else { // Only when pointerEventName == EventTypeNames::pointermove
         pointerEventInit.setButton(NoButton);
     }
     pointerEventInit.setPressure(getPointerEventPressure(
         mouseEvent.pointerProperties().force, pointerEventInit.buttons()));
 
+    // Set width/height to 1 because it matches Edge (and supported by the spec).
+    pointerEventInit.setWidth(1);
+    pointerEventInit.setHeight(1);
+
     UIEventWithKeyState::setFromPlatformModifiers(pointerEventInit, mouseEvent.getModifiers());
 
     // Make sure chorded buttons fire pointermove instead of pointerup/down.
     if ((pointerEventName == EventTypeNames::pointerdown
         && (buttons & ~MouseEvent::buttonToButtons(mouseEvent.button())) != 0)
         || (pointerEventName == EventTypeNames::pointerup && buttons != 0))
         pointerEventName = EventTypeNames::pointermove;
 
 
     pointerEventInit.setView(view);
@@ skipping 236 matching lines @@
     if (properties.pointerType
         == WebPointerProperties::PointerType::Mouse)
         return PointerEventFactory::s_mouseId;
     IncomingId id(properties.pointerType, properties.id);
     if (m_pointerIncomingIdMapping.contains(id))
         return m_pointerIncomingIdMapping.get(id);
     return PointerEventFactory::s_invalidId;
 }
 
 } // namespace blink