Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp

Issue 1968653002: Rename flags for Origin Trials framework (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
diff --git a/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp b/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
index 7c2e011fa6cfa35b1686f119ae2262772469f596..341a3da3ac49176c2a5b5e44d9ea888758a05c88 100644
--- a/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
+++ b/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
@@ -77,18 +77,15 @@ private:
class OriginTrialContextTest : public ::testing::Test {
protected:
OriginTrialContextTest()
- : m_frameworkWasEnabled(RuntimeEnabledFeatures::experimentalFrameworkEnabled())
iclelland 2016/05/11 16:23:44 This is more than a rename -- is it also unnecessa
chasej 2016/05/11 19:05:39 It might be premature to remove this now, but the
iclelland 2016/05/11 19:14:50 I don't think it's premature -- I'd quickly LGTM b
chasej 2016/05/11 19:33:13 Changed to rename, instead of cleanup.
- , m_executionContext(new NullExecutionContext())
+ : m_executionContext(new NullExecutionContext())
, m_tokenValidator(adoptPtr(new MockTokenValidator()))
, m_originTrialContext(new OriginTrialContext(m_executionContext.get()))
, m_histogramTester(new HistogramTester())
{
- RuntimeEnabledFeatures::setExperimentalFrameworkEnabled(true);
}
~OriginTrialContextTest()
{
- RuntimeEnabledFeatures::setExperimentalFrameworkEnabled(m_frameworkWasEnabled);
}
MockTokenValidator* tokenValidator() { return m_tokenValidator.get(); }
@@ -137,7 +134,6 @@ protected:
}
private:
- const bool m_frameworkWasEnabled;
Persistent<NullExecutionContext> m_executionContext;
OwnPtr<MockTokenValidator> m_tokenValidator;
Persistent<OriginTrialContext> m_originTrialContext;

Powered by Google App Engine
This is Rietveld 408576698