Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1968593003: VM: Fix precompiler running with multiple iterations. (Closed)

Created:
4 years, 7 months ago by Florian Schneider
Modified:
4 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Fix precompiler running with multiple iterations. Static initializers were accidentally skipped when doing >1 rounds of precompilation. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/fca36e299d2ea736b53f3aa6eeaa836038460833

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M runtime/vm/precompiler.cc View 1 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
lgtm https://codereview.chromium.org/1968593003/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/1968593003/diff/1/runtime/vm/precompiler.cc#newcode778 runtime/vm/precompiler.cc:778: Function::Handle(CompileStaticInitializer(field)); Handle(Z, ...
4 years, 7 months ago (2016-05-10 19:43:04 UTC) #2
Florian Schneider
Thanks! https://codereview.chromium.org/1968593003/diff/1/runtime/vm/precompiler.cc File runtime/vm/precompiler.cc (right): https://codereview.chromium.org/1968593003/diff/1/runtime/vm/precompiler.cc#newcode778 runtime/vm/precompiler.cc:778: Function::Handle(CompileStaticInitializer(field)); On 2016/05/10 19:43:04, rmacnak wrote: > Handle(Z, ...
4 years, 7 months ago (2016-05-10 19:49:59 UTC) #3
Florian Schneider
4 years, 7 months ago (2016-05-10 19:51:38 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
fca36e299d2ea736b53f3aa6eeaa836038460833 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698