PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle

components/offline_pages/background/offliner.h

Index: components/offline_pages/background/offliner.h
diff --git a/components/offline_pages/background/offliner.h b/components/offline_pages/background/offliner.h
index e24506075929e32a397a30ef24ecc81c1450f289..2b58ccb34ffd18141e5bee7d9a7c52b4f4596571 100644
--- a/components/offline_pages/background/offliner.h
+++ b/components/offline_pages/background/offliner.h
@@ -15,18 +15,19 @@ class SavePageRequest;
 // a request with a URL.
 class Offliner {
  public:
-  // Completion status of processing an offline page request.
-  enum CompletionStatus {
-    SAVED = 0,
-    CANCELED = 1,
-    FAILED_CONSIDER_RETRY = 2,
-    FAILED_DO_NOT_RETRY = 3,
-    UNKNOWN = 4,
+  // Status of processing an offline page request.
+  enum class RequestStatus {
+    UNKNOWN,                // No status determined/reported yet.
+    LOADED,                 // Page loaded but not (yet) saved.
+    SAVED,                  // Offline page snapshot saved.
+    CANCELED,               // Request was canceled.
+    FAILED_CONSIDER_RETRY,  // Failed in a way that is subject to retry.

[pasko, 2016/05/17 16:26:32]

We should do our best to avoid dead code, let's introduce new enum values not
earlier than a use of them is introduced. This way it would be easier to review
the changes to follow.

[dougarnett, 2016/05/18 00:37:48]

Done.

+    FAILED_DO_NOT_RETRY,    // Failed in a way that is not subject to retry.
   };
 
   // Reports the completion status of a request.
   // TODO(dougarnett): consider passing back a request id instead of request.
-  typedef base::Callback<void(const SavePageRequest&, CompletionStatus)>
+  typedef base::Callback<void(const SavePageRequest&, RequestStatus)>
       CompletionCallback;
 
   Offliner() {}