Chromium Code Reviews| Index: components/offline_pages/background/offliner.h |
| diff --git a/components/offline_pages/background/offliner.h b/components/offline_pages/background/offliner.h |
| index 8145cc8dadf7c924d76a65acf1d51286c010b4bb..2b58ccb34ffd18141e5bee7d9a7c52b4f4596571 100644 |
| --- a/components/offline_pages/background/offliner.h |
| +++ b/components/offline_pages/background/offliner.h |
| @@ -15,17 +15,19 @@ class SavePageRequest; |
| // a request with a URL. |
| class Offliner { |
| public: |
| - // Completion status of processing an offline page request. |
| - enum CompletionStatus { |
| - SAVED = 0, |
| - CANCELED = 1, |
| - FAILED_CONSIDER_RETRY = 2, |
| - FAILED_DO_NOT_RETRY = 3, |
| + // Status of processing an offline page request. |
| + enum class RequestStatus { |
| + UNKNOWN, // No status determined/reported yet. |
| + LOADED, // Page loaded but not (yet) saved. |
| + SAVED, // Offline page snapshot saved. |
| + CANCELED, // Request was canceled. |
| + FAILED_CONSIDER_RETRY, // Failed in a way that is subject to retry. |
|
gabadie
2016/05/13 07:55:38
Sorry, but where is this guy used?
dougarnett
2016/05/13 17:03:59
The RequestCoordinator (not part of this CL) uses
|
| + FAILED_DO_NOT_RETRY, // Failed in a way that is not subject to retry. |
| }; |
| // Reports the completion status of a request. |
| // TODO(dougarnett): consider passing back a request id instead of request. |
| - typedef base::Callback<void(const SavePageRequest&, CompletionStatus)> |
| + typedef base::Callback<void(const SavePageRequest&, RequestStatus)> |
| CompletionCallback; |
| Offliner() {} |