PrerenderingLoader initial integration with PrerenderManager/PrerenderHandle

components/offline_pages/background/offliner.h

Index: components/offline_pages/background/offliner.h
diff --git a/components/offline_pages/background/offliner.h b/components/offline_pages/background/offliner.h
index 8145cc8dadf7c924d76a65acf1d51286c010b4bb..cca247706b5e12fe6163a12382d3c81ba87c0243 100644
--- a/components/offline_pages/background/offliner.h
+++ b/components/offline_pages/background/offliner.h
@@ -17,10 +17,12 @@ class Offliner {
  public:
   // Completion status of processing an offline page request.
   enum CompletionStatus {

[pasko, 2016/05/12 19:10:07]

since there are values like "LOADED" with indication that the request is not
completed yet, having "Completion" in the name is misleading.

Suggesting:

offline_pages::OfflineRequestStatus
offline_pages::Offliner::RequestProgressStatus

[dougarnett, 2016/05/13 00:00:24]

Done.

-    SAVED = 0,
-    CANCELED = 1,
-    FAILED_CONSIDER_RETRY = 2,
-    FAILED_DO_NOT_RETRY = 3,
+    UNKNOWN = 0,                // No completion status determined/reported yet.

[pasko, 2016/05/12 19:10:07]

this value is not used in the code, use it in a test or remove.

[dougarnett, 2016/05/13 00:00:24]

Actually meant to use in unit tests so added initialization.
Or is there decent way to test for undefined value?

+    LOADED = 1,                 // Page loaded but not (yet) saved.
+    SAVED = 2,                  // Offline page snapshot saved.
+    CANCELED = 3,               // Request was canceled.
+    FAILED_CONSIDER_RETRY = 4,  // Failed in a way that is subject to retry.
+    FAILED_DO_NOT_RETRY = 5,

[pasko, 2016/05/12 19:10:07]

do we need numerical constants here?

Scoped enums (i.e. "enum class") are preferable in this case.

[dougarnett, 2016/05/13 00:00:24]

Done.

   };
 
   // Reports the completion status of a request.