Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: components/offline_pages/offline_page_model_unittest.cc

Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adding a missing fix to gypi file Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_unittest.cc
diff --git a/components/offline_pages/offline_page_model_unittest.cc b/components/offline_pages/offline_page_model_unittest.cc
index fa1b6f6976da8c921a580f962e155d1418a3872c..00d44f6a8cc820c44c5e0a5b419b9c1ae51a0104 100644
--- a/components/offline_pages/offline_page_model_unittest.cc
+++ b/components/offline_pages/offline_page_model_unittest.cc
@@ -28,20 +28,10 @@
#include "components/offline_pages/offline_page_storage_manager.h"
#include "components/offline_pages/offline_page_test_archiver.h"
#include "components/offline_pages/offline_page_test_store.h"
+#include "components/offline_pages/offline_page_types.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "url/gurl.h"
-using SavePageResult = offline_pages::OfflinePageModel::SavePageResult;
-using DeletePageResult = offline_pages::OfflinePageModel::DeletePageResult;
-using SingleOfflinePageItemResult =
- offline_pages::OfflinePageModel::SingleOfflinePageItemResult;
-using MultipleOfflinePageItemResult =
- offline_pages::OfflinePageModel::MultipleOfflinePageItemResult;
-using CheckPagesExistOfflineResult =
- offline_pages::OfflinePageModel::CheckPagesExistOfflineResult;
-using MultipleOfflineIdResult =
- offline_pages::OfflinePageModel::MultipleOfflineIdResult;
-
namespace offline_pages {
namespace {
@@ -130,7 +120,7 @@ class OfflinePageModelTest
OfflinePageArchiver::ArchiverResult result);
void DeletePage(int64_t offline_id,
- const OfflinePageModel::DeletePageCallback& callback) {
+ const DeletePageCallback& callback) {
std::vector<int64_t> offline_ids;
offline_ids.push_back(offline_id);
model()->DeletePagesByOfflineId(offline_ids, callback);
@@ -233,9 +223,8 @@ void OfflinePageModelTest::SetLastPathCreatedByArchiver(
last_archiver_path_ = file_path;
}
-void OfflinePageModelTest::OnSavePageDone(
- OfflinePageModel::SavePageResult result,
- int64_t offline_id) {
+void OfflinePageModelTest::OnSavePageDone(SavePageResult result,
+ int64_t offline_id) {
last_save_result_ = result;
last_save_offline_id_ = offline_id;
}
« no previous file with comments | « components/offline_pages/offline_page_model.cc ('k') | components/offline_pages/offline_page_storage_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698