components/offline_pages/BUILD.gn - Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/BUILD.gn

Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding a missing fix to gypi file Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/offline_pages/BUILD.gn

diff --git a/components/offline_pages/BUILD.gn b/components/offline_pages/BUILD.gn

index 8bb47aa12e0743cf8d59677cca84ace01213aeb8..450ea6743f0475ac6a535cf86937a4e84abe4de0 100644

--- a/components/offline_pages/BUILD.gn

+++ b/components/offline_pages/BUILD.gn

@@ -25,6 +25,7 @@ static_library("offline_pages") {

"offline_page_model.h",

"offline_page_storage_manager.cc",

"offline_page_storage_manager.h",

+ "offline_page_types.h",

"snapshot_controller.cc",

"snapshot_controller.h",

]

@@ -99,7 +100,7 @@ source_set("unit_tests") {

if (is_android) {

java_cpp_enum("offline_page_model_enums_java") {

sources = [

- "offline_page_model.h",

+ "offline_page_types.h",

]

}

« no previous file with comments | « components/offline_pages.gypi ('k') | components/offline_pages/offline_page_model.h » ('j') | no next file with comments »