components/offline_pages/offline_page_storage_manager.cc - Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/offline_page_storage_manager.cc

Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Aliasing 4 result types in the model to reduce the change impact Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/offline_page_model_unittest.cc ('k') | components/offline_pages/offline_page_storage_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/offline_page_storage_manager.cc

diff --git a/components/offline_pages/offline_page_storage_manager.cc b/components/offline_pages/offline_page_storage_manager.cc

index 30a62c5ff86847bca0174462153b713e44c999dd..e4deea95d6e2e8e242fd7ba2c41f595701352113 100644

--- a/components/offline_pages/offline_page_storage_manager.cc

+++ b/components/offline_pages/offline_page_storage_manager.cc

@@ -9,10 +9,7 @@

#include "components/offline_pages/offline_page_client_policy.h"

#include "components/offline_pages/offline_page_item.h"

#include "components/offline_pages/offline_page_model.h"

-using DeletePageResult = offline_pages::OfflinePageModel::DeletePageResult;

-using MultipleOfflinePageItemResult =

- offline_pages::OfflinePageModel::MultipleOfflinePageItemResult;

+#include "components/offline_pages/offline_page_types.h"

dewittj 2016/05/11 18:42:56 you could revert this file, if you like.

fgorski 2016/05/11 19:14:20 I did it on purpose to prevent another aliasing of

namespace offline_pages {