chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc - Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc

Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Aliasing 4 result types in the model to reduce the change impact Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/android/offline_pages/offline_page_utils_unittest.cc » ('j') | components/offline_pages/offline_page_storage_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc b/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc

index bcec1accd9f800aed18946fe6dff504636db8d62..d271a2124b0b48468dc4745ace4df8c348384b53 100644

--- a/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc

+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc

@@ -18,16 +18,13 @@

#include "components/offline_pages/offline_page_item.h"

#include "components/offline_pages/offline_page_model.h"

#include "components/offline_pages/offline_page_test_archiver.h"

+#include "components/offline_pages/offline_page_types.h"

#include "content/public/browser/navigation_entry.h"

#include "content/public/browser/web_contents.h"

#include "net/base/net_errors.h"

#include "net/base/network_change_notifier.h"

#include "testing/gtest/include/gtest/gtest.h"

-using SavePageResult = offline_pages::OfflinePageModel::SavePageResult;

-using SingleOfflinePageItemResult =

- offline_pages::OfflinePageModel::SingleOfflinePageItemResult;

namespace offline_pages {

namespace {