Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(980)

Unified Diff: chrome/browser/android/offline_pages/recent_tab_helper.cc

Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/recent_tab_helper.cc
diff --git a/chrome/browser/android/offline_pages/recent_tab_helper.cc b/chrome/browser/android/offline_pages/recent_tab_helper.cc
index 6f5fc9b3aa3fa722ad8772020c4f17e94b469871..10fadf0e7383dcacda38c556c4582f7d46699429 100644
--- a/chrome/browser/android/offline_pages/recent_tab_helper.cc
+++ b/chrome/browser/android/offline_pages/recent_tab_helper.cc
@@ -148,12 +148,11 @@ void RecentTabHelper::ContinueSnapshotWithIdsToPurge(
weak_ptr_factory_.GetWeakPtr()));
}
-void RecentTabHelper::ContinueSnapshotAfterPurge(
- OfflinePageModel::DeletePageResult result) {
+void RecentTabHelper::ContinueSnapshotAfterPurge(DeletePageResult result) {
// NOT_FOUND is because it's what we get when passing empty vector of ids.
// TODO(dimich): remove NOT_FOUND when bug 608057 is fixed.
- if (result != OfflinePageModel::DeletePageResult::SUCCESS &&
- result != OfflinePageModel::DeletePageResult::NOT_FOUND) {
+ if (result != DeletePageResult::SUCCESS &&
+ result != DeletePageResult::NOT_FOUND) {
// If previous pages can't be deleted, don't add new ones.
ReportSnapshotCompleted();
return;
@@ -178,7 +177,7 @@ void RecentTabHelper::ContinueSnapshotAfterPurge(
weak_ptr_factory_.GetWeakPtr()));
}
-void RecentTabHelper::SavePageCallback(OfflinePageModel::SavePageResult result,
+void RecentTabHelper::SavePageCallback(SavePageResult result,
int64_t offline_id) {
// TODO(dimich): add UMA, including result. Bug 608112.
ReportSnapshotCompleted();

Powered by Google App Engine
This is Rietveld 408576698