chrome/browser/android/offline_pages/offline_page_utils_unittest.cc - Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

Issue 1968563003: [Offline pages] Extracting callbacks from the Offline Page Model (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc ('k') | chrome/browser/android/offline_pages/recent_tab_helper.h » ('j') | components/offline_pages.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

diff --git a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

index c102154885631fd13f1f7fc6313660b674336881..8753c4863b8b3da2348a336322b942adb9ca432a 100644

--- a/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

+++ b/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc

@@ -54,8 +54,7 @@ class OfflinePageUtilsTest

void RunUntilIdle();

// Necessary callbacks for the offline page model.

- void OnSavePageDone(OfflinePageModel::SavePageResult result,

- int64_t offlineId);

+ void OnSavePageDone(SavePageResult result, int64_t offlineId);

void OnClearAllDone();

// OfflinePageTestArchiver::Observer implementation:

@@ -118,9 +117,8 @@ void OfflinePageUtilsTest::RunUntilIdle() {

task_runner_->RunUntilIdle();

}

-void OfflinePageUtilsTest::OnSavePageDone(

- OfflinePageModel::SavePageResult result,

- int64_t offline_id) {

+void OfflinePageUtilsTest::OnSavePageDone(SavePageResult result,

+ int64_t offline_id) {

offline_id_ = offline_id;

}