Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: mojo/public/cpp/application/lib/application_impl.cc

Issue 1968543003: Remove ServiceRegistry's support for exposed services. (Closed) Base URL: https://github.com/domokit/mojo.git@work790
Patch Set: asdf Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/cpp/application/lib/service_registry.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/cpp/application/lib/application_impl.cc
diff --git a/mojo/public/cpp/application/lib/application_impl.cc b/mojo/public/cpp/application/lib/application_impl.cc
index 23c58ae6966bb8a50efd67bcf9d9c786813d2944..ea1c200a38c5d8f42ad8f9834836533f67843d11 100644
--- a/mojo/public/cpp/application/lib/application_impl.cc
+++ b/mojo/public/cpp/application/lib/application_impl.cc
@@ -64,12 +64,13 @@ void ApplicationImpl::AcceptConnection(
InterfaceRequest<ServiceProvider> services,
InterfaceHandle<ServiceProvider> exposed_services,
const String& url) {
- MOJO_LOG_IF(WARNING, exposed_services)
- << "DEPRECATION WARNING: exposed_services will soon go away";
+ // Note: The shell no longer actually connects |exposed_services|, so a) we
+ // never actually get valid |exposed_services| here, b) it should be OK to
+ // drop it on the floor.
+ MOJO_LOG_IF(ERROR, exposed_services)
+ << "DEPRECATED: exposed_services is going away";
std::unique_ptr<internal::ServiceRegistry> registry(
- new internal::ServiceRegistry(this, url, requestor_url,
- std::move(exposed_services),
- services.Pass()));
+ new internal::ServiceRegistry(url, requestor_url, services.Pass()));
if (!delegate_->ConfigureIncomingConnection(registry.get()))
return;
incoming_service_registries_.push_back(std::move(registry));
« no previous file with comments | « no previous file | mojo/public/cpp/application/lib/service_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698