Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1968533002: Flip PerformanceObserver flag to stable (Closed)

Created:
4 years, 7 months ago by panicker
Modified:
4 years, 7 months ago
Reviewers:
esprehn, skobes, dglazkov, nduca
CC:
blink-reviews, chromium-reviews, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Flip PerformanceObserver flag to stable BUG=485613 Committed: https://crrev.com/90c50a84ac263a6d354e657e82ae3c48f00e6fad Cr-Commit-Position: refs/heads/master@{#393376}

Patch Set 1 #

Patch Set 2 : Update test expectations for layout tests in virtual/stable post flag flip #

Messages

Total messages: 28 (12 generated)
panicker
PTAL. Anything else needed to flip the flag?
4 years, 7 months ago (2016-05-10 18:07:41 UTC) #2
skobes
rslgtm but someone on perf team should probably approve as well.
4 years, 7 months ago (2016-05-10 18:16:17 UTC) #3
nduca
lgtm
4 years, 7 months ago (2016-05-10 19:58:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968533002/1
4 years, 7 months ago (2016-05-10 20:37:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/180702)
4 years, 7 months ago (2016-05-10 20:48:27 UTC) #8
panicker
Need OWNERS approval.
4 years, 7 months ago (2016-05-10 21:09:15 UTC) #10
esprehn
lgtm
4 years, 7 months ago (2016-05-11 17:41:03 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968533002/1
4 years, 7 months ago (2016-05-11 17:46:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/227177)
4 years, 7 months ago (2016-05-11 19:03:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968533002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968533002/1
4 years, 7 months ago (2016-05-11 21:17:45 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/227370)
4 years, 7 months ago (2016-05-11 22:29:28 UTC) #19
panicker
Need API_OWNERs after fixing layout test expectations, with the flag change
4 years, 7 months ago (2016-05-12 20:45:10 UTC) #21
dglazkov
lgtm
4 years, 7 months ago (2016-05-12 20:49:26 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968533002/20001
4 years, 7 months ago (2016-05-12 20:55:47 UTC) #25
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-12 22:18:39 UTC) #26
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 22:20:17 UTC) #28
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90c50a84ac263a6d354e657e82ae3c48f00e6fad
Cr-Commit-Position: refs/heads/master@{#393376}

Powered by Google App Engine
This is Rietveld 408576698