Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1968503002: Revert of Site Settings Android: A few polish items. (Closed)

Created:
4 years, 7 months ago by Finnur
Modified:
4 years, 7 months ago
Reviewers:
Theresa, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Site Settings Android: A few polish items. (patchset #6 id:180001 of https://codereview.chromium.org/1947493002/ ) Reason for revert: Caused crbug.com/610576 Original issue's description: > Site Settings Android: A few polish items. > > From issue 601918: > - Change "+ Add site" blue action link to be "+ Add site exception" > - Change dialog text to be: "Allow [JavaScript/the permission in question etc.] for a specific site." > > From issue 467788: > - Update the individual site settings page toggles with verbs that match the permissions bubbles > > From issue 604753 (partial fix): > - Improve alignment of Site Settings list a bit (move icon a bit to the right). > - Color the Site List heading blue. > > Also add an updated image for Protected Content (slightly larger) and the Media icon, which is for > the container menu that will house Protected Content and Autoplay. > > BUG=601918, 467788, 604753 > > Committed: https://crrev.com/2d4101ec17e44ff061d5e65bc52f386d9985e881 > Cr-Commit-Position: refs/heads/master@{#392363} TBR=twellington@chromium.org,dfalcantara@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601918, 467788, 604753 Committed: https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951 Cr-Commit-Position: refs/heads/master@{#392612}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -92 lines) Patch
M chrome/android/java/res/drawable-hdpi/permission_protected_media.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/settings_media.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-mdpi/permission_protected_media.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/settings_media.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xhdpi/permission_protected_media.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/settings_media.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xxhdpi/permission_protected_media.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/settings_media.png View Binary file 0 comments Download
M chrome/android/java/res/drawable-xxxhdpi/permission_protected_media.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/settings_media.png View Binary file 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/android/java/res/xml/site_settings_preferences.xml View 1 chunk +14 lines, -14 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/ExpandablePreferenceGroup.java View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ContentSettingsResources.java View 3 chunks +7 lines, -7 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SiteSettingsPreference.java View 1 chunk +0 lines, -35 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 3 chunks +13 lines, -24 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Finnur
Created Revert of Site Settings Android: A few polish items.
4 years, 7 months ago (2016-05-10 15:25:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968503002/1
4 years, 7 months ago (2016-05-10 15:25:28 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-10 15:26:12 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 15:27:33 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/04e90ff9a7f58302c97fe4a0c14dd12e41f89951
Cr-Commit-Position: refs/heads/master@{#392612}

Powered by Google App Engine
This is Rietveld 408576698