Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 1968493002: [wasm] Introduce special bytecodes for asm.js division/remainder instead of relying on module state. (Closed)

Created:
4 years, 7 months ago by titzer
Modified:
4 years, 7 months ago
Reviewers:
bradnelson, ahaas
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Introduce special bytecodes for asm.js division/remainder instead of relying on module state. R=ahaas@chromium.org, bradnelson@chromium.org BUG= Committed: https://crrev.com/067a0d6c61f6dea73d92c4a6b999ed9671635b44 Cr-Commit-Position: refs/heads/master@{#36148}

Patch Set 1 #

Patch Set 2 : Move asm.js tests to their own file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -189 lines) Patch
M src/compiler/wasm-compiler.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 5 chunks +96 lines, -85 lines 0 comments Download
M src/wasm/asm-wasm-builder.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M src/wasm/wasm-opcodes.h View 1 chunk +24 lines, -23 lines 0 comments Download
M test/cctest/cctest.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 2 chunks +0 lines, -75 lines 0 comments Download
A test/cctest/wasm/test-run-wasm-asmjs.cc View 1 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
titzer
4 years, 7 months ago (2016-05-10 14:47:24 UTC) #1
bradnelson
lgtm, seems better to move away from module state (then we can pickle the result).
4 years, 7 months ago (2016-05-10 17:56:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968493002/20001
4 years, 7 months ago (2016-05-10 17:56:29 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-10 17:58:12 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-10 17:58:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/067a0d6c61f6dea73d92c4a6b999ed9671635b44
Cr-Commit-Position: refs/heads/master@{#36148}

Powered by Google App Engine
This is Rietveld 408576698