[turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators.

[turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators.

Trying to re-land http://crrev.com/1948453002 after fixing assembler-x64.cc in http://crrev.com/1962563003.

Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter.

Committed: https://crrev.com/2da70f853d7f680d491c37c72d5ef04a85497ba9
Cr-Commit-Position: refs/heads/master@{#36136}

[epertoso, 2016-05-10 10:56:37]

Description was changed from

==========
[turbofan] Take the immediate size in account when narrowing ia32/x64 word
coparison operators.

Trying to reland http://crrev.com/1948453002 after fixing assembler-x64.cc in
http://crrev.com/1962563003.

Before this patch, we would emit a cmp or test with a memory operand only if
both of the operands in the IR were loads. Now if either of them is a load and
the other one is an immediate, we can use a memory operand if the load
representation machine size is wide enough to represent the latter.
==========

to

==========
[turbofan] Take the immediate size in account when narrowing ia32/x64 word
comparison operators.

Trying to reland http://crrev.com/1948453002 after fixing assembler-x64.cc in
http://crrev.com/1962563003.

Before this patch, we would emit a cmp or test with a memory operand only if
both of the operands in the IR were loads. Now if either of them is a load and
the other one is an immediate, we can use a memory operand if the load
representation machine size is wide enough to represent the latter.
==========

[epertoso, 2016-05-10 10:57:03]

Description was changed from

==========
[turbofan] Take the immediate size in account when narrowing ia32/x64 word
comparison operators.

Trying to reland http://crrev.com/1948453002 after fixing assembler-x64.cc in
http://crrev.com/1962563003.

Before this patch, we would emit a cmp or test with a memory operand only if
both of the operands in the IR were loads. Now if either of them is a load and
the other one is an immediate, we can use a memory operand if the load
representation machine size is wide enough to represent the latter.
==========

to

==========
[turbofan] Take the immediate size in account when narrowing ia32/x64 word
comparison operators.

Trying to re-land http://crrev.com/1948453002 after fixing assembler-x64.cc in
http://crrev.com/1962563003.

Before this patch, we would emit a cmp or test with a memory operand only if
both of the operands in the IR were loads. Now if either of them is a load and
the other one is an immediate, we can use a memory operand if the load
representation machine size is wide enough to represent the latter.
==========

[epertoso, 2016-05-10 10:57:51]

epertoso@chromium.org changed reviewers:
+ bmeurer@chromium.org, titzer@chromium.org

[epertoso, 2016-05-10 10:58:31]

I'm not sure the test is in the correct file.

[epertoso, 2016-05-10 10:58:36]

The CQ bit was checked by epertoso@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-10 10:58:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968453002/1

[Benedikt Meurer, 2016-05-10 10:59:16]

Ok with me. LGTM.

[titzer, 2016-05-10 11:00:19]

lgtm

[commit-bot: I haz the power, 2016-05-10 11:33:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-10 11:33:39]

Dry run: This issue passed the CQ dry run.

[epertoso, 2016-05-10 12:07:59]

The CQ bit was checked by epertoso@chromium.org

[commit-bot: I haz the power, 2016-05-10 12:08:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968453002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968453002/1

[commit-bot: I haz the power, 2016-05-10 12:09:27]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-10 12:10:01]

Description was changed from

==========
[turbofan] Take the immediate size in account when narrowing ia32/x64 word
comparison operators.

Trying to re-land http://crrev.com/1948453002 after fixing assembler-x64.cc in
http://crrev.com/1962563003.

Before this patch, we would emit a cmp or test with a memory operand only if
both of the operands in the IR were loads. Now if either of them is a load and
the other one is an immediate, we can use a memory operand if the load
representation machine size is wide enough to represent the latter.
==========

to

==========
[turbofan] Take the immediate size in account when narrowing ia32/x64 word
comparison operators.

Trying to re-land http://crrev.com/1948453002 after fixing assembler-x64.cc in
http://crrev.com/1962563003.

Before this patch, we would emit a cmp or test with a memory operand only if
both of the operands in the IR were loads. Now if either of them is a load and
the other one is an immediate, we can use a memory operand if the load
representation machine size is wide enough to represent the latter.

Committed: https://crrev.com/2da70f853d7f680d491c37c72d5ef04a85497ba9
Cr-Commit-Position: refs/heads/master@{#36136}
==========

[commit-bot: I haz the power, 2016-05-10 12:10:02]

Patchset 1 (id:??) landed as
https://crrev.com/2da70f853d7f680d491c37c72d5ef04a85497ba9
Cr-Commit-Position: refs/heads/master@{#36136}

[titzer, 2016-05-20 13:32:42]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1995303003/ by titzer@chromium.org.

The reason for reverting is: Breaks a KCS demo:

BUG=chromium:611976.

[titzer, 2016-05-20 13:34:56]

On 2016/05/20 13:32:42, titzer wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/1995303003/ by mailto:titzer@chromium.org.
> 
> The reason for reverting is: Breaks a KCS demo:
> 
> BUG=chromium:611976.

Test coverage for this optimization is low, as this is the second time we've
rountripped to Chromium before noticing we broke something. Please add a
significant number of new tests, including instruction selector tests before
relanding.