Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 1968413003: [MD settings] fix for html in i18n string (Closed)

Created:
4 years, 7 months ago by dschuyler
Modified:
4 years, 7 months ago
Reviewers:
Dan Beam, michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD settings] fix for html in i18n string This CL changes a $i18n replacement to a $i18nRaw replacement because the replacement contains html. BUG=611312 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/83ec61cd920277f2cb059fbba37bfac35ad8221d Cr-Commit-Position: refs/heads/master@{#393623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/settings/privacy_page/privacy_page.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
dschuyler
4 years, 7 months ago (2016-05-12 18:31:02 UTC) #3
Dan Beam
lgtm
4 years, 7 months ago (2016-05-12 18:32:42 UTC) #5
michaelpg
lgtm
4 years, 7 months ago (2016-05-13 05:34:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968413003/1
4 years, 7 months ago (2016-05-13 18:17:02 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-13 20:40:26 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 20:42:54 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83ec61cd920277f2cb059fbba37bfac35ad8221d
Cr-Commit-Position: refs/heads/master@{#393623}

Powered by Google App Engine
This is Rietveld 408576698