Issue 19684009: Use C++11 static_assert() if available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19684009: Use C++11 static_assert() if available. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer

Modified:
7 years, 5 months ago

Reviewers:
Sven Panne, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Use C++11 static_assert() if available. R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15736

Patch Set 2 : Fix empty line in diff. #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -0 lines)			Patch
	M	src/checks.h	View	1	2 chunks	+8 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

lgtm https://codereview.chromium.org/19684009/diff/3001/src/checks.h File src/checks.h (right): https://codereview.chromium.org/19684009/diff/3001/src/checks.h#newcode237 src/checks.h:237: (defined(__has_extension) && __has_extension(cxx_static_assert)) autoconf by hand? ;-)

7 years, 5 months ago (2013-07-18 06:45:30 UTC) #2

Benedikt Meurer

7 years, 5 months ago (2013-07-18 07:43:45 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r15736 (presubmit successful).

Expand Messages | Collapse Messages

Issue 19684009: Use C++11 static_assert() if available. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix empty line in diff. #

Messages