Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/unittest/lib/compact_vm_config.dart

Issue 19684006: Roll back "Use package:stack_trace in unittest." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/unittest/lib/html_config.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/unittest/lib/compact_vm_config.dart
diff --git a/pkg/unittest/lib/compact_vm_config.dart b/pkg/unittest/lib/compact_vm_config.dart
index 97c120a3e08d95fac6afa97562900735590516e5..64b2021a627c0178e39a403f79b20e0fccbf82fb 100644
--- a/pkg/unittest/lib/compact_vm_config.dart
+++ b/pkg/unittest/lib/compact_vm_config.dart
@@ -15,7 +15,6 @@ import 'dart:io';
import 'dart:isolate';
import 'unittest.dart';
-import 'src/utils.dart';
import 'vm_config.dart';
const String _GREEN = '\u001b[32m';
@@ -58,11 +57,11 @@ class CompactVMConfiguration extends VMConfiguration {
_progressLine(_start, _pass, _fail, test.description);
print('');
if (test.message != '') {
- print(indent(test.message));
+ print(_indent(test.message));
}
- if (test.stackTrace != null) {
- print(indent(test.stackTrace.toString()));
+ if (test.stackTrace != null && test.stackTrace != '') {
+ print(_indent(test.stackTrace));
}
}
}
@@ -76,6 +75,10 @@ class CompactVMConfiguration extends VMConfiguration {
});
}
+ String _indent(String str) {
+ return str.split("\n").map((line) => " $line").join("\n");
+ }
+
void onSummary(int passed, int failed, int errors, List<TestCase> results,
String uncaughtError) {
var success = false;
« no previous file with comments | « no previous file | pkg/unittest/lib/html_config.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698