Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: src/ast/ast.h

Issue 1968383002: Remove Expression::bounds_, in order to conserve memory during parsing. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Remove Expression::bounds_ Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/ast/ast.h
diff --git a/src/ast/ast.h b/src/ast/ast.h
index 203dbd34197893872887622dfd098b112b4da77e..939138ed46b26e2516a5b7de31cb9d3bbcc2a508 100644
--- a/src/ast/ast.h
+++ b/src/ast/ast.h
@@ -337,10 +337,6 @@ class Expression : public AstNode {
// True iff the expression is a valid target for an assignment.
bool IsValidReferenceExpressionOrThis() const;
- // Expression type bounds
- Bounds bounds() const { return bounds_; }
- void set_bounds(Bounds bounds) { bounds_ = bounds; }
-
// Type feedback information for assignments and properties.
virtual bool IsMonomorphic() {
UNREACHABLE();
@@ -374,7 +370,6 @@ class Expression : public AstNode {
Expression(Zone* zone, int pos)
: AstNode(pos),
base_id_(BailoutId::None().ToInt()),
- bounds_(Bounds::Unbounded()),
bit_field_(0) {}
static int parent_num_ids() { return 0; }
void set_to_boolean_types(uint16_t types) {
@@ -390,7 +385,6 @@ class Expression : public AstNode {
int local_id(int n) const { return base_id() + parent_num_ids() + n; }
int base_id_;
- Bounds bounds_;
class ToBooleanTypesField : public BitField16<uint16_t, 0, 9> {};
uint16_t bit_field_;
// Ends with 16-bit field; deriving classes in turn begin with
« no previous file with comments | « BUILD.gn ('k') | src/ast/ast-type-bounds.h » ('j') | test/cctest/test-ast-expression-visitor.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698