Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5330)

Unified Diff: chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java

Issue 1968353002: Upstream: Add URL intent filter to WebAPK (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/webapk/shell_apk/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
diff --git a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java b/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
index 386c216bb612f370d908953944adb5111c035ca1..4557fa9ff49471051d4d17a7a82cb921d812ffc4 100644
--- a/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
+++ b/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java
@@ -54,6 +54,13 @@ public class MainActivity extends Activity {
packageName, PackageManager.GET_META_DATA);
Bundle bundle = appInfo.metaData;
url = bundle.getString(META_DATA_HOST_URL);
+
+ String overrideUrl = getIntent().getDataString();
+ // TODO(pkotwicz): Use same logic as {@code IntentHandler#shouldIgnoreIntent()}
+ if (overrideUrl != null && overrideUrl.startsWith("https:")) {
+ url = overrideUrl;
+ }
+
scope = bundle.getString(META_DATA_SCOPE);
webappId = WebApkConstants.WEBAPK_ID_PREFIX + packageName;
mac = bundle.getString(META_DATA_MAC);
@@ -95,4 +102,13 @@ public class MainActivity extends Activity {
bitmap.compress(Bitmap.CompressFormat.PNG, 100, output);
return Base64.encodeToString(output.toByteArray(), Base64.DEFAULT);
}
+
+ /**
+ * Returns whether a url is valid.
+ * @param url The url to check.
+ * @return Whether the url is valid.
+ */
+ private static boolean isUrlValid(String url) {
Yaron 2016/05/12 13:45:12 nit: remove
+ return url != null && url.startsWith("https:");
+ }
}
« no previous file with comments | « chrome/android/webapk/shell_apk/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698