Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1968353002: Upstream: Add URL intent filter to WebAPK (Closed)

Created:
4 years, 7 months ago by pkotwicz
Modified:
4 years, 7 months ago
Reviewers:
Xi Han, Yaron
CC:
chromium-reviews, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add URL intent filter to WebAPK BUG=609122 Committed: https://crrev.com/f5e26dfd36051ad0b87a25ac0e2d3554b09c0c6b Cr-Commit-Position: refs/heads/master@{#393253}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M chrome/android/webapk/shell_apk/AndroidManifest.xml View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pkotwicz
Xi can you please take a look?
4 years, 7 months ago (2016-05-12 02:32:37 UTC) #3
Yaron
lgtm https://codereview.chromium.org/1968353002/diff/20001/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java File chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java (right): https://codereview.chromium.org/1968353002/diff/20001/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java#newcode111 chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/MainActivity.java:111: private static boolean isUrlValid(String url) { nit: remove
4 years, 7 months ago (2016-05-12 13:45:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968353002/40001
4 years, 7 months ago (2016-05-12 14:12:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-12 15:24:04 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-12 15:26:38 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/f5e26dfd36051ad0b87a25ac0e2d3554b09c0c6b
Cr-Commit-Position: refs/heads/master@{#393253}

Powered by Google App Engine
This is Rietveld 408576698