Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 196833005: Don't call Chrome::print() if there is a provisional DocumentLoader (Closed)

Created:
6 years, 9 months ago by Nate Chapin
Modified:
6 years, 9 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, gavinp+loader_chromium.org
Visibility:
Public.

Description

Don't call Chrome::print() if there is a provisional DocumentLoader In this case, the frame isn't done loading, and we may attempt to print something bogus. BUG=339075 TEST=Manually, on a google presentation with --enable-print-preview Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169509

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/frame/DOMWindow.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
Nate Chapin
I don't have a good idea for how to write a test for this.
6 years, 9 months ago (2014-03-18 17:54:36 UTC) #1
abarth-chromium
It's kind of lame not to have a test, but ok. LGTM
6 years, 9 months ago (2014-03-18 22:49:48 UTC) #2
Nate Chapin
On 2014/03/18 22:49:48, abarth wrote: > It's kind of lame not to have a test, ...
6 years, 9 months ago (2014-03-18 22:52:32 UTC) #3
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-18 22:52:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/196833005/20001
6 years, 9 months ago (2014-03-18 22:52:50 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 22:57:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 9 months ago (2014-03-18 22:57:24 UTC) #7
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-18 23:00:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/196833005/20001
6 years, 9 months ago (2014-03-18 23:00:33 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-18 23:21:05 UTC) #10
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
6 years, 9 months ago (2014-03-18 23:21:06 UTC) #11
Nate Chapin
The CQ bit was checked by japhet@chromium.org
6 years, 9 months ago (2014-03-18 23:22:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/196833005/20001
6 years, 9 months ago (2014-03-18 23:22:42 UTC) #13
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 02:52:17 UTC) #14
Message was sent while issue was closed.
Change committed as 169509

Powered by Google App Engine
This is Rietveld 408576698