Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1968293004: WebRTC: Enable MB on our remaining Chromium builders. (Closed)

Created:
4 years, 7 months ago by kjellander_chromium
Modified:
4 years, 7 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

WebRTC: Enable MB on our remaining Chromium builders. MB needs to be used to flip to GN. Remove the building of the 'chromium_builder_webrtc' target since it doesn't exist in GN. It's just a legacy convenience target that used to be needed to get the tools 'frame_analyzer' and 'rgba_to_i420_converter' built. Today they're already built since configured for the bots in https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.webrtc.json https://code.google.com/p/chromium/codesearch#chromium/src/testing/buildbot/chromium.webrtc.fyi.json MB configs are being added in https://codereview.chromium.org/1980443002/ BUG=611326 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300572

Patch Set 1 #

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968293004/1
4 years, 7 months ago (2016-05-13 08:44:26 UTC) #2
kjellander_chromium
4 years, 7 months ago (2016-05-13 08:44:37 UTC) #4
kjellander_chromium
On 2016/05/13 08:44:37, kjellander (chromium) wrote: Oh, this CL depends on adding more MB configs ...
4 years, 7 months ago (2016-05-13 08:45:53 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 08:47:57 UTC) #7
kjellander_chromium
On 2016/05/13 08:45:53, kjellander (chromium) wrote: > On 2016/05/13 08:44:37, kjellander (chromium) wrote: > > ...
4 years, 7 months ago (2016-05-13 08:52:19 UTC) #9
phoglund_chromium
lgtm
4 years, 7 months ago (2016-05-13 09:04:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1968293004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1968293004/1
4 years, 7 months ago (2016-05-13 09:40:20 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-13 09:43:17 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=300572

Powered by Google App Engine
This is Rietveld 408576698