Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1289)

Unified Diff: chrome/browser/spellchecker/spellcheck_service_browsertest.cc

Issue 1968293002: Disable SpellcheckServiceBrowserTest.StartWithoutLanguages on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/spellchecker/spellcheck_service_browsertest.cc
diff --git a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
index 0ebe0aa41b46a5ac1bba3563f1da77f62828c9eb..01ea9a2313fbf7babb6b24ed8f52e8fd5abf4ffa 100644
--- a/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
+++ b/chrome/browser/spellchecker/spellcheck_service_browsertest.cc
@@ -230,10 +230,17 @@ IN_PROC_BROWSER_TEST_F(SpellcheckServiceBrowserTest,
EXPECT_FALSE(GetFirstEnableSpellcheckMessageParam());
}
+// Flaky on Windows, see https://crbug.com/611029.
+#if defined(OS_WIN)
+#define MAYBE_StartWithoutLanguages DISABLED_StartWithoutLanguages
+#else
+#define MAYBE_StartWithoutLanguages StartWithoutLanguages
+#endif
// Starting without spellcheck languages should send the 'disable spellcheck'
// message to the renderer. Consequently adding spellchecking languages should
// enable spellcheck.
-IN_PROC_BROWSER_TEST_F(SpellcheckServiceBrowserTest, StartWithoutLanguages) {
+IN_PROC_BROWSER_TEST_F(SpellcheckServiceBrowserTest,
+ MAYBE_StartWithoutLanguages) {
InitSpellcheck(true, "", "");
EXPECT_FALSE(GetFirstEnableSpellcheckMessageParam());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698