Implementing Host List Context Menu and Delete Feature

remoting/android/java/src/org/chromium/chromoting/Chromoting.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chromoting;
 
 import android.annotation.SuppressLint;
 import android.app.ProgressDialog;
 import android.content.DialogInterface;
 import android.content.Intent;
 import android.content.SharedPreferences;
 import android.content.pm.PackageManager;
 import android.content.res.Configuration;
 import android.graphics.drawable.Drawable;
 import android.os.Bundle;
 import android.provider.Settings;
 import android.support.v4.graphics.drawable.DrawableCompat;
 import android.support.v4.widget.DrawerLayout;
 import android.support.v7.app.ActionBarDrawerToggle;
 import android.support.v7.app.AlertDialog;
 import android.support.v7.app.AppCompatActivity;
 import android.support.v7.widget.Toolbar;
+import android.view.ContextMenu;
 import android.view.Gravity;
 import android.view.Menu;
 import android.view.MenuItem;
 import android.view.View;
 import android.widget.AdapterView;
 import android.widget.ArrayAdapter;
 import android.widget.LinearLayout;
 import android.widget.ListView;
 import android.widget.Toast;
 
@@ skipping 144 matching lines @@
         super.onCreate(savedInstanceState);
         setContentView(R.layout.main);
 
         Toolbar toolbar = (Toolbar) findViewById(R.id.toolbar);
         setSupportActionBar(toolbar);
 
         mHostListManager = new HostListManager();
 
         // Get ahold of our view widgets.
         mHostListView = (ListView) findViewById(R.id.hostList_chooser);
+        registerForContextMenu(mHostListView);
         mEmptyView = findViewById(R.id.hostList_empty);
         mHostListView.setOnItemClickListener(
                 new AdapterView.OnItemClickListener() {
                     @Override
                     public void onItemClick(AdapterView<?> parent, View view, int position,
                             long id) {
                         onHostClicked(position);
                     }
                 });
 
@@ skipping 191 matching lines @@
     }
 
     /** Called when the display is rotated (as registered in the manifest). */
     @Override
     public void onConfigurationChanged(Configuration newConfig) {
         super.onConfigurationChanged(newConfig);
 
         mDrawerToggle.onConfigurationChanged(newConfig);
     }
 
+    private static int getHostIndexForMenu(ContextMenu.ContextMenuInfo menuInfo) {
+        return ((AdapterView.AdapterContextMenuInfo) menuInfo).position;
+    }
+
+    @Override
+    public void onCreateContextMenu(ContextMenu menu, View v,
+            ContextMenu.ContextMenuInfo menuInfo) {
+        super.onCreateContextMenu(menu, v, menuInfo);
+        if (v.getId() == R.id.hostList_chooser) {
+            getMenuInflater().inflate(R.menu.options_actionbar, menu);
+            HostInfo info = mHosts[getHostIndexForMenu(menuInfo)];
+            menu.setHeaderTitle(info.name);
+        }
+    }
+
+    @Override
+    public boolean onContextItemSelected(MenuItem item) {
+        int itemId = item.getItemId();
+        int hostIndex = getHostIndexForMenu(item.getMenuInfo());
+        if (itemId == R.id.actionbar_connect) {
+            onHostClicked(hostIndex);
+        } else if (itemId == R.id.actionbar_delete) {
+            HostInfo hostInfo = mHosts[hostIndex];

[Lambros, 2016/05/13 21:17:11]

I would suggest factoring out this block into a separate method (probably taking
a HostInfo parameter), to reduce indentation and keep this method short.

[Yuwei, 2016/05/13 23:43:54]

Done.

+            final String hostId = hostInfo.id;
+            AlertDialog.Builder builder = new AlertDialog.Builder(this);

[Lambros, 2016/05/13 21:17:11]

Maybe remove |builder| temporary and do:

new AlertDialog.Builder(this)
        .setMessage(...)
        .setPositive(...)
...

[Yuwei, 2016/05/13 23:43:54]

Done.

+            String message = getString(R.string.confirm_host_delete_android, hostInfo.name);
+            builder.setMessage(message)
+                    .setPositiveButton(android.R.string.yes,
+                            new DialogInterface.OnClickListener() {
+                                @Override
+                                public void onClick(DialogInterface dialog, int which) {
+                                    deleteHost(hostId);
+                                    dialog.dismiss();
+                                }
+                            })
+                    .setNegativeButton(android.R.string.no, null)
+                    .create().show();
+        } else {
+            return false;
+        }
+        return true;
+    }
+
     /** Called to initialize the action bar. */
     @Override
     public boolean onCreateOptionsMenu(Menu menu) {
         getMenuInflater().inflate(R.menu.chromoting_actionbar, menu);
         mRefreshButton = menu.findItem(R.id.actionbar_directoryrefresh);
 
         if (mAccount == null) {
             // If there is no account, don't allow the user to refresh the listing.
             mRefreshButton.setEnabled(false);
         }
@@ skipping 233 matching lines @@
                 // Unreachable, but required by Google Java style and findbugs.
                 assert false : "Unreached";
         }
 
         if (dismissProgress && mProgressIndicator != null) {
             mProgressIndicator.dismiss();
             mProgressIndicator = null;
         }
     }
 }