Clean up CFX_ImageStretcher.

Clean up CFX_ImageStretcher.

Committed: https://pdfium.googlesource.com/pdfium/+/9febfe6373f26d9e59eb1e137b88a2aeff5dc39a

[Lei Zhang, 2016-05-11 23:53:29]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-05-12 00:03:08]

lgtm

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_en...
File core/fxge/dib/fx_dib_engine.cpp (right):

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_en...
core/fxge/dib/fx_dib_engine.cpp:16: const int kMaxProgressiveStretchPixels =
1000000;
Ok for now, but seems kinda small.  A megapixel?

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_en...
core/fxge/dib/fx_dib_engine.cpp:799: FX_Free(m_pScanline);
can these be unique_ptr<..., FreeDeleter> ?

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_ma...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_ma...
core/fxge/dib/fx_dib_main.cpp:1650: m_pTransformer->Start(pSource, &m_Matrix,
dib_flags, &m_ClipBox);
Looks like the same cleanup could be applied here.

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_tr...
File core/fxge/dib/fx_dib_transform.cpp (right):

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_tr...
core/fxge/dib/fx_dib_transform.cpp:331: stretcher.Continue(nullptr);
Do we ever call this with non-nullptr?

[Lei Zhang, 2016-05-12 01:17:13]

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_en...
File core/fxge/dib/fx_dib_engine.cpp (right):

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_en...
core/fxge/dib/fx_dib_engine.cpp:16: const int kMaxProgressiveStretchPixels =
1000000;
On 2016/05/12 00:03:08, Tom Sepez wrote:
> Ok for now, but seems kinda small.  A megapixel?

I have no idea why it's so small.

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_en...
core/fxge/dib/fx_dib_engine.cpp:799: FX_Free(m_pScanline);
On 2016/05/12 00:03:08, Tom Sepez wrote:
> can these be unique_ptr<..., FreeDeleter> ?

Done.

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_ma...
File core/fxge/dib/fx_dib_main.cpp (right):

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_ma...
core/fxge/dib/fx_dib_main.cpp:1650: m_pTransformer->Start(pSource, &m_Matrix,
dib_flags, &m_ClipBox);
On 2016/05/12 00:03:08, Tom Sepez wrote:
> Looks like the same cleanup could be applied here.

Yep, but that'll have to be another day.

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_tr...
File core/fxge/dib/fx_dib_transform.cpp (right):

https://codereview.chromium.org/1968273002/diff/40001/core/fxge/dib/fx_dib_tr...
core/fxge/dib/fx_dib_transform.cpp:331: stretcher.Continue(nullptr);
On 2016/05/12 00:03:08, Tom Sepez wrote:
> Do we ever call this with non-nullptr?

Yes, we pass a pPause variable in sometimes. Whether that is always NULL or
not... who knows.

[Lei Zhang, 2016-05-12 01:17:19]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-05-12 01:17:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1968273002/#ps60001
(title: "More")

[commit-bot: I haz the power, 2016-05-12 01:17:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1968273002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1968273002/60001

[commit-bot: I haz the power, 2016-05-12 01:31:24]

Description was changed from

==========
Clean up CFX_ImageStretcher.
==========

to

==========
Clean up CFX_ImageStretcher.

Committed:
https://pdfium.googlesource.com/pdfium/+/9febfe6373f26d9e59eb1e137b88a2aeff5d...
==========

[commit-bot: I haz the power, 2016-05-12 01:31:25]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/9febfe6373f26d9e59eb1e137b88a2aeff5d...

[caryclark, 2016-05-12 14:25:06]

On 2016/05/12 01:31:25, commit-bot: I haz the power wrote:
> Committed patchset #4 (id:60001) as
>
https://pdfium.googlesource.com/pdfium/+/9febfe6373f26d9e59eb1e137b88a2aeff5d...

The next time you change the antigrain driver, would you mind dropping me a note
so I can keep the Skia driver in sync? That would be very helpful. Thanks!

[Lei Zhang, 2016-05-12 16:58:39]

On 2016/05/12 14:25:06, caryclark wrote:
> On 2016/05/12 01:31:25, commit-bot: I haz the power wrote:
> > Committed patchset #4 (id:60001) as
> >
>
https://pdfium.googlesource.com/pdfium/+/9febfe6373f26d9e59eb1e137b88a2aeff5d...
> 
> The next time you change the antigrain driver, would you mind dropping me a
note
> so I can keep the Skia driver in sync? That would be very helpful. Thanks!

Sounds like we need a bot with Skia enabled?