src/mips64/builtins-mips64.cc - Issue 1968263002: Remove unused 'receiver' field from generators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips64/builtins-mips64.cc

Issue 1968263002: Remove unused 'receiver' field from generators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: weaken dcheck Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips64/builtins-mips64.cc

diff --git a/src/mips64/builtins-mips64.cc b/src/mips64/builtins-mips64.cc

index 4cd9a388916ee6f41317d6b999f71d3c9ebcbe4b..e8d38a65ffa430b4c38e9fae9df8a9beff828ecd 100644

--- a/src/mips64/builtins-mips64.cc

+++ b/src/mips64/builtins-mips64.cc

@@ -721,9 +721,8 @@ void Builtins::Generate_ResumeGeneratorTrampoline(MacroAssembler* masm) {

}

__ bind(&skip_flooding);

- // Push receiver.

- __ ld(a5, FieldMemOperand(a1, JSGeneratorObject::kReceiverOffset));

- __ Push(a5);

+ // Push hole for the never-used receiver, similarly to arguments below.

+ __ PushRoot(Heap::kTheHoleValueRootIndex);

// ----------- S t a t e -------------

// -- a1 : the JSGeneratorObject to resume

« no previous file with comments | « src/mips/builtins-mips.cc ('k') | src/objects.h » ('j') | no next file with comments »