src/ia32/builtins-ia32.cc - Issue 1968263002: Remove unused 'receiver' field from generators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/builtins-ia32.cc

Issue 1968263002: Remove unused 'receiver' field from generators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: weaken dcheck Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/builtins-ia32.cc

diff --git a/src/ia32/builtins-ia32.cc b/src/ia32/builtins-ia32.cc

index a9759a2df96a54705eb7ced005a6f3cdc8ed96ca..6d01b7f06d3f811a6b26027bcb26b4cb7e61796d 100644

--- a/src/ia32/builtins-ia32.cc

+++ b/src/ia32/builtins-ia32.cc

@@ -427,8 +427,8 @@ void Builtins::Generate_ResumeGeneratorTrampoline(MacroAssembler* masm) {

// Pop return address.

__ PopReturnAddressTo(eax);

- // Push receiver.

- __ Push(FieldOperand(ebx, JSGeneratorObject::kReceiverOffset));

+ // Push hole for the never-used receiver, similarly to arguments below.

+ __ PushRoot(Heap::kTheHoleValueRootIndex);

// ----------- S t a t e -------------

// -- eax : return address

« no previous file with comments | « src/debug/mirrors.js ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »