src/arm64/builtins-arm64.cc - Issue 1968263002: Remove unused 'receiver' field from generators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/builtins-arm64.cc

Issue 1968263002: Remove unused 'receiver' field from generators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: weaken dcheck Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm64/builtins-arm64.cc

diff --git a/src/arm64/builtins-arm64.cc b/src/arm64/builtins-arm64.cc

index 81f01188bd2e8e3ac194a67224450c4234f1c28d..4a4dd72463fd6fdc87f4e0cee7054adcf3bc6bb5 100644

--- a/src/arm64/builtins-arm64.cc

+++ b/src/arm64/builtins-arm64.cc

@@ -742,9 +742,8 @@ void Builtins::Generate_ResumeGeneratorTrampoline(MacroAssembler* masm) {

}

__ bind(&skip_flooding);

- // Push receiver.

- __ Ldr(x5, FieldMemOperand(x1, JSGeneratorObject::kReceiverOffset));

- __ Push(x5);

+ // Push hole for the never-used receiver, similarly to arguments below.

+ __ LoadRoot(x11, Heap::kTheHoleValueRootIndex);

// ----------- S t a t e -------------

// -- x1 : the JSGeneratorObject to resume

« no previous file with comments | « src/arm/builtins-arm.cc ('k') | src/debug/mirrors.js » ('j') | no next file with comments »