Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Side by Side Diff: src/x64/builtins-x64.cc

Issue 1968263002: Remove unused 'receiver' field from generators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: weaken dcheck Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_X64 5 #if V8_TARGET_ARCH_X64
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 __ CallRuntime(Runtime::kDebugPrepareStepInIfStepping); 494 __ CallRuntime(Runtime::kDebugPrepareStepInIfStepping);
495 __ Pop(rdx); 495 __ Pop(rdx);
496 __ Pop(rbx); 496 __ Pop(rbx);
497 __ movp(rdi, FieldOperand(rbx, JSGeneratorObject::kFunctionOffset)); 497 __ movp(rdi, FieldOperand(rbx, JSGeneratorObject::kFunctionOffset));
498 } 498 }
499 __ bind(&skip_flooding); 499 __ bind(&skip_flooding);
500 500
501 // Pop return address. 501 // Pop return address.
502 __ PopReturnAddressTo(rax); 502 __ PopReturnAddressTo(rax);
503 503
504 // Push receiver. 504 // Push hole for the never-used receiver, similarly to arguments below.
505 __ Push(FieldOperand(rbx, JSGeneratorObject::kReceiverOffset)); 505 __ PushRoot(Heap::kTheHoleValueRootIndex);
506 506
507 // ----------- S t a t e ------------- 507 // ----------- S t a t e -------------
508 // -- rax : return address 508 // -- rax : return address
509 // -- rbx : the JSGeneratorObject to resume 509 // -- rbx : the JSGeneratorObject to resume
510 // -- rdx : the resume mode (tagged) 510 // -- rdx : the resume mode (tagged)
511 // -- rdi : generator function 511 // -- rdi : generator function
512 // -- rsi : generator context 512 // -- rsi : generator context
513 // -- rsp[0] : generator receiver 513 // -- rsp[0] : generator receiver
514 // ----------------------------------- 514 // -----------------------------------
515 515
(...skipping 2439 matching lines...) Expand 10 before | Expand all | Expand 10 after
2955 __ ret(0); 2955 __ ret(0);
2956 } 2956 }
2957 2957
2958 2958
2959 #undef __ 2959 #undef __
2960 2960
2961 } // namespace internal 2961 } // namespace internal
2962 } // namespace v8 2962 } // namespace v8
2963 2963
2964 #endif // V8_TARGET_ARCH_X64 2964 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/runtime/runtime-generator.cc ('k') | test/cctest/interpreter/bytecode_expectations/Generators.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698