Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: src/ia32/builtins-ia32.cc

Issue 1968263002: Remove unused 'receiver' field from generators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: weaken dcheck Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/debug/mirrors.js ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_IA32 5 #if V8_TARGET_ARCH_IA32
6 6
7 #include "src/code-factory.h" 7 #include "src/code-factory.h"
8 #include "src/codegen.h" 8 #include "src/codegen.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
420 __ CallRuntime(Runtime::kDebugPrepareStepInIfStepping); 420 __ CallRuntime(Runtime::kDebugPrepareStepInIfStepping);
421 __ Pop(edx); 421 __ Pop(edx);
422 __ Pop(ebx); 422 __ Pop(ebx);
423 __ mov(edi, FieldOperand(ebx, JSGeneratorObject::kFunctionOffset)); 423 __ mov(edi, FieldOperand(ebx, JSGeneratorObject::kFunctionOffset));
424 } 424 }
425 __ bind(&skip_flooding); 425 __ bind(&skip_flooding);
426 426
427 // Pop return address. 427 // Pop return address.
428 __ PopReturnAddressTo(eax); 428 __ PopReturnAddressTo(eax);
429 429
430 // Push receiver. 430 // Push hole for the never-used receiver, similarly to arguments below.
431 __ Push(FieldOperand(ebx, JSGeneratorObject::kReceiverOffset)); 431 __ PushRoot(Heap::kTheHoleValueRootIndex);
432 432
433 // ----------- S t a t e ------------- 433 // ----------- S t a t e -------------
434 // -- eax : return address 434 // -- eax : return address
435 // -- ebx : the JSGeneratorObject to resume 435 // -- ebx : the JSGeneratorObject to resume
436 // -- edx : the resume mode (tagged) 436 // -- edx : the resume mode (tagged)
437 // -- edi : generator function 437 // -- edi : generator function
438 // -- esi : generator context 438 // -- esi : generator context
439 // -- esp[0] : generator receiver 439 // -- esp[0] : generator receiver
440 // ----------------------------------- 440 // -----------------------------------
441 441
(...skipping 2453 matching lines...) Expand 10 before | Expand all | Expand 10 after
2895 // And "return" to the OSR entry point of the function. 2895 // And "return" to the OSR entry point of the function.
2896 __ ret(0); 2896 __ ret(0);
2897 } 2897 }
2898 2898
2899 2899
2900 #undef __ 2900 #undef __
2901 } // namespace internal 2901 } // namespace internal
2902 } // namespace v8 2902 } // namespace v8
2903 2903
2904 #endif // V8_TARGET_ARCH_IA32 2904 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/debug/mirrors.js ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698