Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Side by Side Diff: src/arm/builtins-arm.cc

Issue 1968263002: Remove unused 'receiver' field from generators (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: weaken dcheck Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_ARM 5 #if V8_TARGET_ARCH_ARM
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 718 matching lines...) Expand 10 before | Expand all | Expand 10 after
729 __ b(eq, &skip_flooding); 729 __ b(eq, &skip_flooding);
730 { 730 {
731 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL); 731 FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
732 __ Push(r1, r2, r4); 732 __ Push(r1, r2, r4);
733 __ CallRuntime(Runtime::kDebugPrepareStepInIfStepping); 733 __ CallRuntime(Runtime::kDebugPrepareStepInIfStepping);
734 __ Pop(r1, r2); 734 __ Pop(r1, r2);
735 __ ldr(r4, FieldMemOperand(r1, JSGeneratorObject::kFunctionOffset)); 735 __ ldr(r4, FieldMemOperand(r1, JSGeneratorObject::kFunctionOffset));
736 } 736 }
737 __ bind(&skip_flooding); 737 __ bind(&skip_flooding);
738 738
739 // Push receiver. 739 // Push hole for the never-used receiver, similarly to arguments below.
740 __ ldr(ip, FieldMemOperand(r1, JSGeneratorObject::kReceiverOffset)); 740 __ PushRoot(Heap::kTheHoleValueRootIndex);
741 __ Push(ip);
742 741
743 // ----------- S t a t e ------------- 742 // ----------- S t a t e -------------
744 // -- r1 : the JSGeneratorObject to resume 743 // -- r1 : the JSGeneratorObject to resume
745 // -- r2 : the resume mode (tagged) 744 // -- r2 : the resume mode (tagged)
746 // -- r4 : generator function 745 // -- r4 : generator function
747 // -- cp : generator context 746 // -- cp : generator context
748 // -- lr : return address 747 // -- lr : return address
749 // -- sp[0] : generator receiver 748 // -- sp[0] : generator receiver
750 // ----------------------------------- 749 // -----------------------------------
751 750
(...skipping 2058 matching lines...) Expand 10 before | Expand all | Expand 10 after
2810 } 2809 }
2811 } 2810 }
2812 2811
2813 2812
2814 #undef __ 2813 #undef __
2815 2814
2816 } // namespace internal 2815 } // namespace internal
2817 } // namespace v8 2816 } // namespace v8
2818 2817
2819 #endif // V8_TARGET_ARCH_ARM 2818 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm64/builtins-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698